Update to Doctrine ORM 3.2 #10257 #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by:
The whole PR must be reviewed again before merging. And |
Without this, the record would not exist anymore in DB when we try to get the file path in `deleteFile()`. And then we could not delete the file on disk after the record deletion.
We don't need our custom implementation since ORM now supports string backed enum mapped to ENUM columns natively.
Because most enums use native ORM implementation, and the few enums left as pure string also don't need the comments to work anymore.
Because Doctrine will write to log before connecting, and thus will re-create a second connection to log to DB. Except that we don't log low priority log to DB, so nothing is ever written, but a second connection is still created for nothing. And that second connection leads to painful DB deadlock in unit tests, because we may log some things on one connection, while the other, main, connection is inside a transaction. To prevent all of this mess, the DB connection for logging is lazy-evaluated, and only retrieved when we actually write the first log to DB.
Because laminas-log and laminas-mail are both discontinued. And we do it now, because the migration to doctrine 3 exposed a cyclic dependency issue in Epicerio. The end result was we were trying to log something to DB before a connection to DB was established, and so we established a second connection to DB, wrecking havoc in our apps. So instead of deep diving in laminas-log to sort out all the details, I'd rather deep dive in monolog directly and clear the technical debt at the same time. And since monolog has an integration with symfony/mailer, it seemed natural to do that too, and clear even more technical debt. And to avoid the double-connection issue, the DB logger is only active, and only retrieves its dependencies, after we are certain that a connection to DB was established. The overall concept of our logs remains unchanged though. We have 3 log destinations: File, Mail and DB. Mail and DB have extra information through `RecordCompleter`. File does not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.