feat(wallet): add testnet banner and improve send flow validation#480
feat(wallet): add testnet banner and improve send flow validation#480web3nova wants to merge 2 commits into
Conversation
…alidation - Added environment config for testnet detection - Testnet banner now conditionally shows based on STELLAR_NETWORK - Added send confirmation dialog before transaction submission - Amount validation now rounds to 2 decimal places - Fixed recipient validation with debouncing (already present) Closes Echo-Mirror-Butler#460
|
@web3nova Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
akintewe
left a comment
akintewe
left a comment
There was a problem hiding this comment.
Great work overall — testnet banner, confirmation dialog, and amount validation are all correct. One issue blocking merge:
Duplicate onChanged block in wallet_screen.dart: The amount validation logic appears twice in the same onChanged handler — once with double-quoted strings, then again with single-quoted strings. This will cause a Dart compile error. Please remove the second (single-quoted) duplicate block starting at final parsed = double.tryParse(value.trim()); around line 250 and keep only the first block.
Once that's fixed this is ready to merge.
2 participants
Summary
Adds missing testnet indicator and fixes recipient validation UX in the send ECHO modal.
Changes
Testing
--dart-define=STELLAR_NETWORK=testnet→ banner showsCloses #460