Open
Conversation
magoorden
approved these changes
Apr 7, 2023
Contributor
magoorden
left a comment
magoorden
left a comment
There was a problem hiding this comment.
Not many comments on this one 😃.
|
|
||
| @Override | ||
| public void println(Object x) { | ||
| switch (urgency) { |
Contributor
There was a problem hiding this comment.
I am missing the default case for this switch statement.
Author
There was a problem hiding this comment.
Nice catch. I guess an exception should be thrown like colorize. However, I think it can be dangerous to allow logging to throw exceptions so maybe logging exceptions should just use "Error" as default and colorize should not use any color?
Contributor
There was a problem hiding this comment.
I would still throw an exception, as reaching the default case is clearly a developer error, as the developer tries to do something with the Log class that it does not support. An end-user should not reach this point in the code.
added 2 commits
April 13, 2023 09:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for lazy evaluation of the object to log. To enable this a
Supplieris used on eachUrgency. Also someSystem.err.printlnwas used and one print of theExceptionstacktrace. Because of thisLognow supports the printing of theExceptionstacktrace with theLogPrintStream. For now the default method of printing exceptions uses theUrgency.Errorbut allows an overloaded method to have a customUrgency.