Open
Conversation
added 6 commits
March 30, 2023 09:10
Draft
magoorden
requested changes
Apr 7, 2023
| @@ -548,9 +594,10 @@ public CDD applyReset(int[] clockResets, int[] clockValues, int[] boolResets, in | |||
| throw new IllegalArgumentException("The amount of boolean resets and values must be the same"); | |||
Contributor
There was a problem hiding this comment.
Suggested change
| throw new IllegalArgumentException("The amount of boolean resets and values must be the same"); | |
| throw new IllegalArgumentException("The number of boolean resets and values must be the same"); |
Co-authored-by: Martijn Goorden <36483423+magoorden@users.noreply.github.com>
Co-authored-by: Martijn Goorden <36483423+magoorden@users.noreply.github.com>
…oej/j-Ecdar into feat/CDD-deferred-compute
… of an upstream change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second iteration on CDD with deferred computation which was previoslu done with "dirty" flags. In this new iteration a class encapsulating this dirty flag behaviour is created and used by CDD. The aim is to remove complex logic from
CDDrelated to keeping the correct state.Description
DeferredPropertyclass which supports the otherDeferredPropertyas observers to be set asdirtyas soon as the parent is.isTrueandisFalsenow checks the terminal nodes and not the equality and the true and false equalities checks the corresponding terminal nodes.