[NBL-480]: Update table components to support multi selection #2065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pavlos-pavlopoulos-ebury
approved these changes
Apr 3, 2025
Contributor
pavlos-pavlopoulos-ebury
left a comment
pavlos-pavlopoulos-ebury
left a comment
There was a problem hiding this comment.
Looks good!
pavlos-pavlopoulos-ebury
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the smart-table, table and heading components to allow adding an optional column that contains checkboxes to select things in the table. We should also be able to pass an
isSelectableCheckfunction so that we can filter which rows can be selectable.** changes to onRowClick behaviour - the
onRowClickfn should only be called when clicking anywhere in the row besides the checkbox cell - we usually want to open up a details panel when clicking on the row and this makes sure that selecting a row won't also open up that panel.Using the new props in the activity log table (new Neyes functionality) - without passing
isSelectableCheck:Using
isSelectableCheckso only the changes in the table that have a status of 'pending your approval' can be selected:Check out this PR https://github.com/Ebury/eburyonline/pull/2440 for the full implementation.