Refactor: 에러 처리 및 UserConverter 수정 #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamtorygoals
approved these changes
Aug 13, 2025
2anizirong
approved these changes
Aug 13, 2025
| // 이메일 중복 검사 | ||
| if (userRepository.existsByEmail(request.getEmail())) { | ||
| throw new IllegalArgumentException("이미 사용 중인 이메일입니다."); | ||
| throw new ExceptionHandler(ErrorStatus.DUPLICATE_EMAIL); |
Member
There was a problem hiding this comment.
ErrorStatus 임포트 할 때 import static EatPic.spring.global.common.code.status.ErrorStatus.*; 이런 식으로 해서 그냥 DUPLICATE_NICKNAME 에러 상수만 호출하는 식으로 추후에 리펙토링 하면 좋을 것 같습니다. 수고하셨습니당~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
스크린샷