Skip to content

Fix incorrect types #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix incorrect types #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0efdad1
Update Address.d.ts
bensontrent Mar 16, 2024
a4501f8
Update ShipmentCreateParameters.d.ts
bensontrent Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions types/Address/Address.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export declare interface IAddress extends IObjectWithId<'Address'> {
/**
* ZIP or postal code the address is located in
*/
zip: string;
zip?: string;

/**
* ISO 3166 country code for the country the address is located in
Expand Down Expand Up @@ -99,7 +99,7 @@ export declare class Address implements IAddress {
street2?: string | null;
city?: string | null;
state?: string | null;
zip: string;
zip?: string;
country: string;
residential?: boolean | null;
carrier_facility?: string | null;
Expand Down
13 changes: 13 additions & 0 deletions types/Shipment/ShipmentCreateParameters.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,19 @@ export declare interface IShipmentCreateParameters {
*/
carrier_accounts?: string[] | null;

/**
* Optional service name to create one-call-buy shipment
*/
service?: string | null;

tax_identifiers?: TaxIdentifier[] | null
customs_info?: DeepPartial<ICustomsInfo> | null;
options?: DeepPartial<IOptions> | null;
}

type TaxIdentifier = {
entity: "SENDER" | "RECIPIENT"
tax_id: string,
tax_id_type: string;
issuing_country: string
}