Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Checkbox,RadioGroupItem,Toggle): support clickable elements in text #1625

Merged
merged 2 commits into from
Mar 5, 2025
Merged

fix(Checkbox,RadioGroupItem,Toggle): support clickable elements in text #1625

merged 2 commits into from
Mar 5, 2025
+49 −0

Conversation

stephenjwatkins
Copy link
Member

📝 Changes

  • fixes our checkboxes, radios, and toggles to allow links and buttons to be clickable inside of their labels. this would support our use case on the sign up page, for instance, that includes terms and privacy links

✅ Checklist

Easy UI has certain UX standards that must be met. In general, non-trivial changes should meet the following criteria:

  • Visuals match Design Specs in Figma
  • Stories accompany any component changes
  • Code is in accordance with our style guide
  • Design tokens are utilized
  • Unit tests accompany any component changes
  • TSDoc is written for any API surface area
  • Specs are up-to-date
  • Console is free from warnings
  • No accessibility violations are reported
  • Cross-browser check is performed (Chrome, Safari, Firefox)
  • Changeset is added

Strikethrough any items that are not applicable to this pull request.

@stephenjwatkins stephenjwatkins marked this pull request as ready for review March 4, 2025 21:36
ralexmatthews
ralexmatthews approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@ralexmatthews ralexmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stephenjwatkins stephenjwatkins merged commit 05f9b32 into main Mar 5, 2025
5 checks passed
@stephenjwatkins stephenjwatkins deleted the toggle_links branch March 5, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexmatthews ralexmatthews ralexmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenjwatkins @ralexmatthews