Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GetObjectValue for ValueKind.Number #288

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Fix GetObjectValue for ValueKind.Number #288

merged 1 commit into from
Dec 22, 2023

Conversation

inikulshin
Copy link
Contributor

@inikulshin inikulshin commented Dec 22, 2023 •
edited
Loading

#263

Without explicit cast to (object) the returned value is always double.

Pliner
Pliner approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@Pliner Pliner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good finding, thanks

@Pliner Pliner merged commit bffc080 into EasyNetQ:master Dec 22, 2023
5 checks passed
@inikulshin inikulshin deleted the GetObjectValue branch December 24, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pliner Pliner Pliner approved these changes

@zidad zidad Awaiting requested review from zidad zidad is a code owner

@micdenny micdenny Awaiting requested review from micdenny micdenny is a code owner

@luigiberrettini luigiberrettini Awaiting requested review from luigiberrettini luigiberrettini is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inikulshin @Pliner