Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Consumer.ChannelDetails nullable #276

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Make Consumer.ChannelDetails nullable #276

merged 4 commits into from
Dec 7, 2023

Conversation

davidda
Copy link
Contributor

@davidda davidda commented Nov 28, 2023

ChannelDetails can actually be returned null by the RabbitMQ API. In this case I was getting an exception "[NullGuard] ChannelDetails is null".

@zidad zidad enabled auto-merge (squash) November 29, 2023 07:03
@Pliner Pliner disabled auto-merge December 1, 2023 10:03
@Pliner Pliner merged commit 98e9dd2 into EasyNetQ:master Dec 7, 2023
@Pliner
Copy link
Member

Pliner commented Dec 7, 2023

Thanks @davidda!

@davidda davidda deleted the channel-details-fix branch December 7, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pliner Pliner Pliner approved these changes

@zidad zidad Awaiting requested review from zidad zidad is a code owner

@micdenny micdenny Awaiting requested review from micdenny micdenny is a code owner

@luigiberrettini luigiberrettini Awaiting requested review from luigiberrettini luigiberrettini is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidda @Pliner