GH-28 Add auto remove whitelisted ips when using only ee auth delete <sitename>
#54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
Approach
Since there is already a different code to handle the case when we provide
--ip
option , therefore we have to handle it in the normal case.I have checked for a particular condition which is when user only execute
ee auth delete <sitename>
command.NOTE: since it was design earlier to delete auths only , and user specific auths also , so there is possibility that user can pass a
username
, that is why we have to check for the above conditionNow in this condition , we will be deleting whitelisted ips along with deleting the auths.
We have to first delete whitelisted ips if any because , it doesn't throw any error if there are no whitelisted ips already.
Deleting auths first will hault the code execution when there are no auths on the site as it will throw a error.