Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-28 Add auto remove whitelisted ips when using only ee auth delete <sitename> #54

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

PiyushKhurana
Copy link

Fixes #28

Approach

Since there is already a different code to handle the case when we provide --ip option , therefore we have to handle it in the normal case.
I have checked for a particular condition which is when user only execute ee auth delete <sitename> command.

NOTE: since it was design earlier to delete auths only , and user specific auths also , so there is possibility that user can pass a username , that is why we have to check for the above condition

Now in this condition , we will be deleting whitelisted ips along with deleting the auths.
We have to first delete whitelisted ips if any because , it doesn't throw any error if there are no whitelisted ips already.
Deleting auths first will hault the code execution when there are no auths on the site as it will throw a error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth delete should delete whitelisted IPs
1 participant