-
Notifications
You must be signed in to change notification settings - Fork 52
Inlined documentation #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ting right theory path/environment.
…pecifying output directory.
@MM45, can you please give a quick description of the syntax and intended usage, either in a PR or in a wiki page? This will help me review, given this should probably be a usage-based review. |
Alright, so this most recent commit should fix all issues with external projects, but don't waste too much time on reviewing yet:
|
Well, that's a coincidence, I was just typing out my previous comment when you replied ^^ Anyways, I guess I should've changed this to a "draft PR", but I forgot. Sorry. See my previous comment. Only after fixing the things I mentioned there it should be reviewed (in my opinion), and I will ping here when that is the case. |
Okay @fdupress, if the checks succeed, I think it should be reviewable: the resources/tests/EasyCrypt_DocGen_Tutorial.ec file should be all you need to get going. Note that the fixes of the issues I mentioned in my first comment here are not there yet, but these are sort-off QOL changes anyways. Let me know if anything is wrong or unclear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must absolutely fix the gendoc/docgen discrepancy. (Spotted once; stopped looking.)
Otherwise good to go if all comments are considered and reasonably dismissable.
Okidokie, I accidentally discovered a bug that made it such that documentation was generated for clones as if they were regular theories. Should be fixed now. |
@fdupress Is the PR ok for you? |
Yes, this is fine: Matthias has addressed my comments. |
@strub I made an attempt at what we discussed: preventing docgen from checking any proofs. Not sure if this is the right approach though. Also, I added a check that prevents exiting if there is an |
No description provided.