-
Notifications
You must be signed in to change notification settings - Fork 50
[external CI]: Update xmss-acai/xmss-fsai & add xmss-common-spec,xmss-spec,xmssmt-spec and xmss-spec-extra #725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's first see how long the jobs take, then decide on how they are split.
This should fix the error in EasyCrypt/easycrypt#725
I think the failure is due to the external repo (formosa-crypto/formosa-xmss) using ssh+git to specify the submodules. I am honestly surprised and confused by the fact that: 1) this succeeds in the formosa-xmss CI but fails here, and 2) this fails with a host key verification issue here. I'll re-run failed jobs before recommending action on the remote side. |
Thanks, @ruipedro16. So now we get to the useful failure: we need to bring Jasmin's The easiest thing to do would be to add an optional field to the external CI job configuration to specify a version of eclib to use (by tag, branch or commit); the external CI job would then go and fetch it. For the time being, we could also take from the external job a path it expects eclib to be set up in. (In the long run, we'll want a proper notion of importable library.) @strub Do you see another way of doing this? |
should I add |
The issue with adding it as a submodule is that we'll also then need to add the namespaced idir to the The issue with not adding it as a submodule is that, at the moment, the best we can do is clone I think the crux of it is that we really want to have libraries that install themselves register that they exist into the easycrypt configuration in one way or another. (So in this case, Jasmin could tell easycrypt, when it is being installed, that Until we have that, I will likely go with option 2: clone jasmin-compiler and point EasyCrypt to it for |
No description provided.