libiso15118: Add response msg interval control #1784
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaHaGit
requested review from
Pietfried,
SebaLukas,
andistorm,
cburandt,
corneliusclaussen,
djchhp,
florinmihut,
hikinggrass,
james-ctc and
mlitre
as code owners
There are EV implementations that can configure request messages within a few milliseconds, which can currently trigger a flood of internal communication. To avoid performance issues, we should therefore wait a certain amount of time after receiving a request message before sending the next response message. The delay of maximum 100 ms should not cause any problems, as the most critical time of the ISO 15118-20 (V2G_SECC_Msg_Performance_Time of the charging loop) is 250 ms. Changes: - introduce MIN_RESPONSE_INTERVAL_MS to manage time between responses - add last_response_tx_time to track last response timestamp - implement delay to ensure minimum interval between response messages Signed-off-by: Fabian Hartung <[email protected]>
FaHaGit
force-pushed
the
feature/libiso_add_response_msg_interval_control
branch
from
3d894d5 to
a010967
Compare
SebaLukas
requested changes
Feb 3, 2026
Member
SebaLukas
left a comment
SebaLukas
left a comment
There was a problem hiding this comment.
In general I like the PR. Wait for some time before sending the response is a good idea.
My problem with this implementation is that it blocks the whole process for 100ms.
That could be really a problem in some cases.
I need to think how to fix this problem not blocking the whole process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
There are EV implementations that can configure request messages within a few milliseconds, which can currently trigger a flood of internal communication. To avoid performance issues, we should therefore wait a certain amount of time after receiving a request message before sending the next response message. The delay of maximum 100 ms should not cause any problems, as the most critical time of the ISO 15118-20 (V2G_SECC_Msg_Performance_Time of the charging loop) is 250 ms.
Already successfully tested in the SIL environment (with a higher delay, because the josev lib based implementation needs ~500ms to configure a request message).
Changes:
Issue ticket number and link
Checklist before requesting a review