Bugfix: Fix BSP enable handling #1780
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaHaGit
requested review from
Pietfried,
SebaLukas,
andistorm,
cburandt,
corneliusclaussen,
djchhp,
dorezyuk,
florinmihut,
hikinggrass,
james-ctc,
mlitre and
rckstrh
as code owners
FaHaGit
changed the title
- specify PWM update handling during disabled state - remove the recommendation for state F dring disabled state as long as EV implementations could enter an error state and require manual opening of the plug lock. Signed-off-by: Fabian Hartung <[email protected]>
- cache last PWM in last_pwm_raw - update pwm_on/off/F to maintain cache - apply cached PWM when handle_enable(true) Signed-off-by: Fabian Hartung <[email protected]>
FaHaGit
force-pushed
the
bugfix/fix_bsp_enable_handling
branch
from
ea323a0 to
1a17400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Until now, the evse_board_support interface description did not document how a BSP should behave when an enable “false” command is set via the interface. The correct behavior was requested in the Zulip chat and has now been corrected. The PhyVersoBSP module did not implement the enable correctly until now. This has also been fixed in this PR.
Issue ticket number and link
--
Checklist before requesting a review