Feature/dynamic_ac_config: Introduce CP state E#1778
Open
FaHaGit wants to merge 5 commits intoEVerest:mainfrom
Open
Feature/dynamic_ac_config: Introduce CP state E#1778FaHaGit wants to merge 5 commits intoEVerest:mainfrom
FaHaGit wants to merge 5 commits intoEVerest:mainfrom
Conversation
FaHaGit
requested review from
Pietfried,
SebaLukas,
andistorm,
cburandt,
corneliusclaussen,
djchhp,
dorezyuk,
florinmihut,
hikinggrass,
james-ctc,
mlitre and
rckstrh
as code owners
FaHaGit
force-pushed
the
feature/dynamic_ac_config/introduce_cp_state_E
branch
2 times, most recently
from
6d664dd to
41ee43f
Compare
- introduce cp_state_E command to set Control Pilot line to 0 V - update YAML and implementation files to handle new command - log warning for unsupported hardware in various drivers - add CP state E button in the BUEvseBoardSupport module Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
…wareCapabilities - update type converters and API to handle new capability - modify board support implementations to initialize supports_cp_state_E Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
- rename all instances of pwm_F to cp_state_F for clarity - update function names, variables, and documentation accordingly Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
- Update function names and references from 'pwm_off' to 'cp_state_X1' across multiple files - Modify test cases and documentation to reflect the changes Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
FaHaGit
force-pushed
the
feature/dynamic_ac_config/introduce_cp_state_E
branch
from
41ee43f to
8f24f6e
Compare
- show HW caps - move button, use different color - fix call Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Under the term “feature/dynamic_ac_config,” we at chargebyte want to integrate the feature for dynamic configuration of an AC session into everest-core in stages.
The first step is to enable the BSP implementation to configure CP state E. This state is used as an alternative to CP state F to initiate a reinitialization of a charging session.
Furthermore, the existing commands were adapted so that the naming matches the new command.
The question remains whether the external API (evse_board_support_API.yaml) should be modified or whether the old naming should be retained. Currently, the external API has also been modified. Feedback would be welcome here.
Summary of changes:
Tests: Successfully tested with sil-dc and sil-ac
Issue ticket number and link
Zulip chat about the board_support refactoring:
https://lfenergy.zulipchat.com/#narrow/channel/417675-EVerest-General/topic/Configuring.20CP.20State.20E.20via.20the.20evse_baord_support.20interface
Zulip chat dynamic AC configuration feature announcement:
https://lfenergy.zulipchat.com/#narrow/channel/417675-EVerest-General/topic/Refactoring.20EvseManager.20for.20Fake.20DC/with/570586322
Checklist before requesting a review