Add ICCID and IMSI modem info to OCPP 2.0.1 BootNotificationRequest #1775
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biubiuzhang
requested review from
Pietfried,
SebaLukas,
andistorm,
cburandt,
corneliusclaussen,
djchhp,
florinmihut,
hikinggrass,
james-ctc and
mlitre
as code owners
biubiuzhang
force-pushed
the
feature/modem-boot-notification
branch
from
6a7da5d to
253a424
Compare
Contributor
|
Hello @biubiuzhang it seems like your changes are failing some unit tests, could you fix the tests? Once those pass, I will be able to approve the PR. |
added 2 commits
February 3, 2026 17:38
Signed-off-by: Nancy Zhang <[email protected]>
Signed-off-by: Nancy Zhang <[email protected]>
biubiuzhang
force-pushed
the
feature/modem-boot-notification
branch
from
a96128c to
b69767b
Compare
Contributor
Author
|
@mlitre thanks for checking! I have ran the unit tests locally and they were all passed. Is there a way I can trigger the pipeline to rerun the failed tests? |
mlitre
approved these changes
Feb 4, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Modify Provisioning::boot_notification_req() in lib/ocpp/v2/functional_blocks/provisioning.cpp to:
Read ICCID and IMSI values from the device model using get_optional_valuestd::string()
If either value is present, create a Modem object and populate the available fields
Attach the Modem object to charging_station.modem
Issue ticket number and link
#1172
Checklist before requesting a review