libiso15118: d2: MeteringReceipt #1760
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Kacper Dalach <[email protected]> Co-authored-by: Kacper Dalach <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
* libiso15118: Add EV/EVSE status structs. These structs are a common part in many messages. * libiso15118: Add EVSEProcessing * libiso15118: Add -2 cable check messages * libiso15118: d2: Add PhysicalValue * libiso15118: d2: Add common DC datatypes. Added datatypes that are common among DC messages. * libiso15118: d2: Add WeldingDetection messages * libiso15118: d2: Add PreCharge messages * libiso15118: d2: Add CurrentDemand messages * libiso15118: d2: Apply requested changes. Applied all of the requested changes. Except for file and struct rename. * libiso15118: d2: Rename files and structs. Renamed all files and structs to have the `DC_` prefix. * libiso15118: d2: Minor fixes in dc messages. Added additional check for optional values in tests. Renamed types to pascal case. --------- Signed-off-by: Kacper Dalach <[email protected]> Co-authored-by: Kacper Dalach <[email protected]>
Fixed SigMeterReading being std::vector instead of std::string. This type is a base64 encoded string. Signed-off-by: Kacper Dalach <[email protected]>
Added MeteringReceipt req/res along with unit tests. Signed-off-by: Kacper Dalach <[email protected]>
Dalachowsky
requested review from
Pietfried,
SebaLukas,
andistorm,
corneliusclaussen,
djchhp,
hikinggrass,
james-ctc and
mlitre
as code owners
SebaLukas
force-pushed
the
feat/adding-iso2-support
branch
from
26677a9 to
e21ac4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added MeteringReceipt req/res along with unit tests.
Also fixed
SigMeterReadingnot beingstd::stringIssue ticket number and link
#1730
Checklist before requesting a review