libiso15118: d2: ChargeParameterDiscovery #1747
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dalachowsky
requested review from
Pietfried,
SebaLukas,
andistorm,
corneliusclaussen,
djchhp,
hikinggrass,
james-ctc and
mlitre
as code owners
SebaLukas
changed the title
SebaLukas
force-pushed
the
feat/adding-iso2-support
branch
from
26677a9 to
e21ac4a
Compare
Dalachowsky
force-pushed
the
feat/adding-iso2-support-charge-parameter-discovery
branch
from
3e7b5e4 to
5c7dded
Compare
Added ChargeParameterDiscovery req/res with tests. There are still a couple of TODOs in the convert functions. These will be resolved after settling the conversation in EVerest#1678. Signed-off-by: Kacper Dalach <[email protected]>
SebaLukas
reviewed
Feb 3, 2026
Added bounds checking for ChargeParameterDiscovery messages. Signed-off-by: Kacper Dalach <[email protected]>
Dalachowsky
force-pushed
the
feat/adding-iso2-support-charge-parameter-discovery
branch
from
5c7dded to
73f3a93
Compare
SebaLukas
requested changes
Feb 4, 2026
Member
SebaLukas
left a comment
SebaLukas
left a comment
There was a problem hiding this comment.
Overall looking good 👍
See my comments
Comment on lines
+122
to
+123
| std::optional<data_types::AcEvChargeParameter> ac_ev_charge_parameter; | ||
| std::optional<data_types::DcEvChargeParameter> dc_ev_charge_parameter; |
Member
There was a problem hiding this comment.
Instead of two optionals I would like to have one std::variant with the Ac and DC EvChargeParameter.
Comment on lines
+132
to
+133
| std::optional<data_types::AcEvseChargeParameter> ac_evse_charge_parameter; | ||
| std::optional<data_types::DcEvseChargeParameter> dc_evse_charge_parameter; |
| auto& schedule_out = out.SAScheduleList.SAScheduleTuple.array[i]; | ||
| convert(schedule_in, schedule_out); | ||
| } | ||
| out.SAScheduleList.SAScheduleTuple.arrayLen = in.sa_schedule_list->size(); |
Member
There was a problem hiding this comment.
Should be sa_schedule_list_max_length, not in.sa_schedule_list->size()
| entry_out.RelativeTimeInterval_isUsed = true; | ||
| convert(entry_in.p_max, entry_out.PMax); | ||
| } | ||
| out.PMaxSchedule.PMaxScheduleEntry.arrayLen = in.pmax_schedule.size(); |
Member
There was a problem hiding this comment.
pmax_schedule_max_length instead of .size()
| auto& entry_out = out.SalesTariff.SalesTariffEntry.array[i]; | ||
| convert(entry_in, entry_out); | ||
| } | ||
| out.SalesTariff.SalesTariffEntry.arrayLen = in.sales_tariff->sales_tariff_entry.size(); |
| auto& cost_out = out.ConsumptionCost.array[i]; | ||
| convert(cost_in, cost_out); | ||
| } | ||
| out.ConsumptionCost.arrayLen = in.consumption_cost.size(); |
| entry_out.amount = entry_in.amount; | ||
| CPP2CB_ASSIGN_IF_USED(entry_in.amount_multiplier, entry_out.amountMultiplier); | ||
| } | ||
| out.Cost.arrayLen = in.cost.size(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added ChargeParameterDiscovery req/res with tests.
There are still a couple of TODOs in the convert functions regarding the array bounds checking. These will be resolved after we decide on how to handle this in #1678.
Because these messages can get quite complex and are quite different in AC and DC charging, the tests were split into multiple cases. Testing the SASchedules was also split into separate test, because this structure gets deep and complicated.
Issue ticket number and link
#1727
Checklist before requesting a review