Feature/eebus rebased #1561
Open
Feature/eebus rebased #1561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlitre
requested review from
Pietfried,
SebaLukas,
a-w50,
andistorm,
corneliusclaussen,
djchhp,
hikinggrass and
james-ctc
as code owners
andistorm
requested changes
Dec 5, 2025
Member
andistorm
left a comment
andistorm
left a comment
There was a problem hiding this comment.
LGTM in general 🐧
The documentation is very helpful
I marked a couple of things that shouldn't be forget before merging
.ci/build-kit/docker/Dockerfile
Outdated
Comment on lines
90
to
98
| # Can be used to use an other version of everest-cmake | ||
| ADD "https://www.random.org/cgi-bin/randbyte?nbytes=10&format=h" skipcache | ||
| ENV EVEREST_CMAKE_PATH=/usr/lib/cmake/everest-cmake | ||
| ENV EVEREST_CMAKE_VERSION=tmp/eebus | ||
| RUN rm -rf ${EVEREST_CMAKE_PATH} \ | ||
| && git clone https://github.com/EVerest/everest-cmake.git ${EVEREST_CMAKE_PATH} \ | ||
| && cd ${EVEREST_CMAKE_PATH} \ | ||
| && git checkout ${EVEREST_CMAKE_VERSION} \ | ||
| && rm -r .git |
Member
There was a problem hiding this comment.
Would be good to move most of it in the ghcr.io/everest/everest-ci/build-env-base image before merging,
Which means opening a PR in everest-ci, merge it, tag a new version/release, use this tag in the ci workflow
| fi | ||
|
|
||
| pip install --break-system-packages \ | ||
| python3 -m pip install --break-system-packages \ |
Member
There was a problem hiding this comment.
Could be in a dedicated PR "Improce CI scripts" or so, but not required from my side
| fi | ||
|
|
||
| pip install --break-system-packages -r tests/ocpp_tests/requirements.txt | ||
| python3 -m pip install --break-system-packages -r tests/ocpp_tests/requirements.txt |
Member
There was a problem hiding this comment.
Could be in a dedicated PR "Improce CI scripts" or so, but not required from my side
|
|
||
| cd tests | ||
| pytest \ | ||
| python3 -m pytest \ |
Member
There was a problem hiding this comment.
Could be in a dedicated PR "Improce CI scripts" or so, but not required from my side
mlitre
force-pushed
the
feature/eebus-rebased
branch
2 times, most recently
from
d1574fe to
0b81a9b
Compare
mlitre
force-pushed
the
feature/eebus-rebased
branch
from
0b81a9b to
bb570fc
Compare
mlitre
force-pushed
the
feature/eebus-rebased
branch
from
bb570fc to
9d047a4
Compare
This is the first implementation of EEBus and the LPC use case. The EEBUS module requires an energy sink to limit the energy flow request going to the energy manager. Signed-off-by: Andreas Heinrich <[email protected]> Signed-off-by: Martin Litre <[email protected]>
Signed-off-by: Martin Litre <[email protected]>
Co-authored-by: Andreas Heinrich <[email protected]> Signed-off-by: Martin Litre <[email protected]>
Signed-off-by: Martin Litre <[email protected]>
Signed-off-by: Martin Litre <[email protected]>
…yle (#1785) * refactor(eebus): Instead of using threads, use a more event driven style Signed-off-by: Martin Litre <[email protected]> * feat(eebus): Make grpc binary restart configurable Signed-off-by: Martin Litre <[email protected]> --------- Signed-off-by: Martin Litre <[email protected]>
mlitre
force-pushed
the
feature/eebus-rebased
branch
from
c2f52ec to
6a5b5b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review