Open
Conversation
- only create xmldsig framgnets which are listed (like other fragments) - remove unused fields for optimization (per default remove "shall not be used" from standard) removed elements are not in structure and will result in en/decoder error NOT_IMPLEMENTED when "isUsed" flag is set. Signed-off-by: Michael Mezger <michael.mezger@chargebyte.com>
Author
|
The change is not optimal. |
Contributor
|
Notes for us when reviewing this:
|
Contributor
|
For the record, from my experiments:
Our regression tests seem to pass. |
Contributor
|
If we take this in, we should also do the same optimizations for DIN and ISO 15118-20. Applied to DIN and ISO -20: With a modified version of this PR, rebased on HEAD: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
removed elements are not in structure and will result in en/decoder error NOT_IMPLEMENTED when "isUsed" flag is set or element is accessed in decoder.
Issue ticket number and link
Feature request #75
Checklist before requesting a review