Skip to content

[refactor] test 코드 점검 #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Syrbear merged 9 commits into from
Jun 16, 2025
Merged

[refactor] test 코드 점검 #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e61b484
[#192] 더미레코드 수정으로 메모레포 테스트 통과
Syrbear Jun 13, 2025
83b83b8
[#192] QuoteRepo Test 복구
Syrbear Jun 13, 2025
20a9ea5
[#192] RecordRepository Test 복구
Syrbear Jun 13, 2025
5064d01
[#192] UserInfoRepositoryTest 복구
Syrbear Jun 13, 2025
d0cad56
[#192] LibraryUseCaseTest 복구
Syrbear Jun 13, 2025
63f208a
[#192] MemoUseCaseTest복구
Syrbear Jun 13, 2025
8496912
[#192] QuoteUseCaseTest복구
Syrbear Jun 13, 2025
ca17cd1
[#192] SummaryRepositoryTest 복구
Syrbear Jun 13, 2025
980171e
[#192] BookService 복구
doyeonk429 Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions B.READ/B.READ.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
Sources/Domain/Repository/Inerface/RecordRepository.swift,
Sources/Domain/Repository/Inerface/SummaryRepository.swift,
Sources/Domain/Repository/Inerface/UserInfoRepository.swift,
"Sources/Util/Extensions/String+.swift",
);
target = 16BE8C682DED50C0006FFD00 /* RepositoryTest */;
};
Expand Down Expand Up @@ -159,6 +160,7 @@
Sources/Network/NetworkClient/RequestConvertible.swift,
"Sources/Util/Extensions/Bundle+.swift",
"Sources/Util/Extensions/Date+.swift",
"Sources/Util/Extensions/String+.swift",
);
target = 16BE931F2DED713E006FFD00 /* ServiceTest */;
};
Expand Down Expand Up @@ -232,6 +234,7 @@
Sources/Network/NetworkClient/RequestConvertible.swift,
"Sources/Util/Extensions/Bundle+.swift",
"Sources/Util/Extensions/Date+.swift",
"Sources/Util/Extensions/String+.swift",
);
target = 16BE95272DED72FB006FFD00 /* UsecaseTest */;
};
Expand Down
40 changes: 20 additions & 20 deletions B.READ/B.READ/Sources/Data/Impls/QuoteRepositoryImpl.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import SwiftData
actor QuoteRepositoryImpl: QuoteRepository {
func createQuote(_ quote: Quote, in record: Record) throws {
print("Impl: \(#function)")

if let _ = try findQuote(id: quote.id) {
throw RepositoryError.dataAlreadyExist
}
Expand All @@ -24,6 +25,7 @@ actor QuoteRepositoryImpl: QuoteRepository {

func updateQuote(_ quote: Quote) throws {
print("Impl: \(#function)")

guard let dto = try findQuote(id: quote.id) else {
throw RepositoryError.dataNotFound
}
Expand All @@ -36,6 +38,7 @@ actor QuoteRepositoryImpl: QuoteRepository {

func deleteQuote(id: String) throws {
print("Impl: \(#function)")

guard let dto = try findQuote(id: id) else {
throw RepositoryError.dataNotFound
}
Expand All @@ -46,20 +49,18 @@ actor QuoteRepositoryImpl: QuoteRepository {

func fetchQuotes(isbn: String) throws -> [Quote] {
print("Impl: \(#function)")
do {
let descriptor = FetchDescriptor<QuoteDTO>(
predicate: #Predicate { $0.isbn == isbn },
sortBy: [.init(\.page, order: .forward)]
)
let dtos = try modelContext.fetch(descriptor)
return dtos.map { $0.toEntity() }
} catch {
throw RepositoryError.fetchError
}

let descriptor = FetchDescriptor<QuoteDTO>(
predicate: #Predicate { $0.isbn == isbn },
sortBy: [.init(\.page, order: .forward)]
)
let dtos = try modelContext.fetch(descriptor)
return dtos.map { $0.toEntity() }
}

func fetchQuote(id: String) throws -> Quote {
print("Impl: \(#function)")

guard let dto = try findQuote(id: id) else {
throw RepositoryError.dataNotFound
}
Expand All @@ -68,15 +69,12 @@ actor QuoteRepositoryImpl: QuoteRepository {

func fetchAllQuotes() throws -> [Quote] {
print("Impl: \(#function)")
do {
let descriptor = FetchDescriptor<QuoteDTO>(
sortBy: [.init(\.page, order: .forward)]
)
let dtos = try modelContext.fetch(descriptor)
return dtos.map { $0.toEntity() }
} catch {
throw RepositoryError.fetchError
}

let descriptor = FetchDescriptor<QuoteDTO>(
sortBy: [.init(\.page, order: .forward)]
)
let dtos = try modelContext.fetch(descriptor)
return dtos.map { $0.toEntity() }
}
}

Expand All @@ -89,8 +87,10 @@ extension QuoteRepositoryImpl {
/// - Returns:
/// - `QuoteDTO?`: 조회된 첫 번째 문장 정보 DTO, 없으면 `nil`
private func findQuote(id: String) throws -> QuoteDTO? {
let predicate = #Predicate<QuoteDTO> { $0.id == id }
let descriptor = FetchDescriptor(predicate: predicate)

do {
let descriptor = FetchDescriptor<QuoteDTO>(predicate: #Predicate { $0.id == id })
return try modelContext.fetch(descriptor).first
} catch {
throw RepositoryError.fetchError
Expand Down
123 changes: 24 additions & 99 deletions B.READ/B.READ/Sources/Domain/Dummy/DummyData.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,110 +144,35 @@ extension DummyData {
currentPage: 252,
review: "",
memos: [
Memo(
id: "1",
isbn: "9788937460586",
createdAt: Calendar.current.date(from: DateComponents(year: 2025, month: 5, day: 4))!,
content: "싯다르타는 수많은 스승과 가르침을 거쳤지만, 결국 삶을 살아가는 과정에서 스스로 진리를 깨닫는다. 남의 말이 아닌, 체험이 지혜로 이어진다.",
pages: (100, 132),
guides: [Guide(date: fixedDate, content: "exmaple1"), Guide(date: fixedDate, content: "exmaple1")]
),
Memo(
id: "2",
isbn: "9788937460586",
createdAt: Calendar.current.date(from: DateComponents(year: 2025, month: 5, day: 4))!,
content: "강을 바라보며 싯다르타는 모든 존재가 연결되어 흐르고 있다는 사실을 깨닫는다. 나 또한 변화와 흐름을 있는 그대로 받아들이고 싶어졌다.",
pages: (100, 132),
guides: [Guide(date: fixedDate, content: "exmaple1"), Guide(date: fixedDate, content: "exmaple1")]
),
Memo(
id: "3",
isbn: "9788937460586",
createdAt: Calendar.current.date(from: DateComponents(year: 2025, month: 5, day: 4))!,
content: "싯다르타의 삶은 고통과 실수의 연속이었지만, 그 모든 것이 깨달음으로 나아가는 길이었다. 나 역시 내 방황을 긍정하고 싶어졌다.",
pages: (100, 132),
guides: [Guide(date: fixedDate, content: "exmaple1"), Guide(date: fixedDate, content: "exmaple1")]
),
// Memo(
// id: "1",
// isbn: "9788937460586",
// createdAt: Calendar.current.date(from: DateComponents(year: 2025, month: 5, day: 4))!,
// content: "싯다르타는 수많은 스승과 가르침을 거쳤지만, 결국 삶을 살아가는 과정에서 스스로 진리를 깨닫는다. 남의 말이 아닌, 체험이 지혜로 이어진다.",
// pages: (100, 132),
// guides: [Guide(date: fixedDate, content: "exmaple1"), Guide(date: fixedDate, content: "exmaple1")]
// ),
// Memo(
// id: "2",
// isbn: "9788937460586",
// createdAt: Calendar.current.date(from: DateComponents(year: 2025, month: 5, day: 4))!,
// content: "강을 바라보며 싯다르타는 모든 존재가 연결되어 흐르고 있다는 사실을 깨닫는다. 나 또한 변화와 흐름을 있는 그대로 받아들이고 싶어졌다.",
// pages: (100, 132),
// guides: [Guide(date: fixedDate, content: "exmaple1"), Guide(date: fixedDate, content: "exmaple1")]
// ),
// Memo(
// id: "3",
// isbn: "9788937460586",
// createdAt: Calendar.current.date(from: DateComponents(year: 2025, month: 5, day: 4))!,
// content: "싯다르타의 삶은 고통과 실수의 연속이었지만, 그 모든 것이 깨달음으로 나아가는 길이었다. 나 역시 내 방황을 긍정하고 싶어졌다.",
// pages: (100, 132),
// guides: [Guide(date: fixedDate, content: "exmaple1"), Guide(date: fixedDate, content: "exmaple1")]
// ),
],
quotes: [],
createdAt: Calendar.current.date(from: DateComponents(year: 2025, month: 4, day: 19))!,
updatedAt: Calendar.current.date(from: DateComponents(year: 2025, month: 5, day: 10))!
)


// Record( // 아주 작은 습관들
// id: UUID().uuidString,
// isbn: "9791162540640",
// state: .reading,
// heartCount: 3,
// starCount: 0,
// isFavorite: true,
// period: (Calendar.current.date(from: DateComponents(year: 2025, month: 3, day: 27)), nil),
// currentPage: 321,
// review: "",
// summaryID: nil,
// memoIDs: [],
// quoteIDs: [],
// createdAt: Calendar.current.date(from: DateComponents(year: 2025, month: 3, day: 26))!,
// updatedAt: Calendar.current.date(from: DateComponents(year: 2025, month: 3, day: 26))!
// ),
// Record( // 위버멘쉬
// id: UUID().uuidString,
// isbn: "9791192372730",
// state: .completed,
// heartCount: 3,
// starCount: 5,
// isFavorite: false,
// period: (
// Calendar.current.date(from: DateComponents(year: 2025, month: 1, day: 1)),
// Calendar.current.date(from: DateComponents(year: 2025, month: 3, day: 5))
// ),
// currentPage: 260,
// review: "",
// summaryID: nil,
// memoIDs: [],
// quoteIDs: [],
// createdAt: Calendar.current.date(from: DateComponents(year: 2025, month: 1, day: 1))!,
// updatedAt: Calendar.current.date(from: DateComponents(year: 2025, month: 1, day: 1))!
// ),
// Record( // 이기적 유전자
// id: UUID().uuidString,
// isbn: "9788932473901",
// state: .completed,
// heartCount: 3,
// starCount: 2,
// isFavorite: false,
// period: (
// Calendar.current.date(from: DateComponents(year: 2025, month: 1, day: 1)),
// Calendar.current.date(from: DateComponents(year: 2025, month: 3, day: 5))
// ),
// currentPage: 632,
// review: "",
// summaryID: nil,
// memoIDs: [],
// quoteIDs: [],
// createdAt: Calendar.current.date(from: DateComponents(year: 2024, month: 12, day: 30))!,
// updatedAt: Calendar.current.date(from: DateComponents(year: 2024, month: 12, day: 30))!
// ),
// Record( // 듀얼 브레인
// id: UUID().uuidString,
// isbn: "9791194368175",
// state: .completed,
// heartCount: 3,
// starCount: 4,
// isFavorite: false,
// period: (
// Calendar.current.date(from: DateComponents(year: 2025, month: 1, day: 1)),
// Calendar.current.date(from: DateComponents(year: 2025, month: 3, day: 5))
// ),
// currentPage: 308,
// review: "",
// summaryID: nil,
// memoIDs: [],
// quoteIDs: [],
// createdAt: Calendar.current.date(from: DateComponents(year: 2024, month: 12, day: 25))!,
// updatedAt: Calendar.current.date(from: DateComponents(year: 2024, month: 12, day: 25))!
// )
]

static var records: [Record] = [
Expand Down
Loading