Add RRTMGP and surface coupling to convection-permitting suite - #422
Conversation
nusbaume
left a comment
There was a problem hiding this comment.
Thanks @kuanchihwang! I just had one optional request and a comment covering the discussion we had in our meeting. Otherwise these changes look good to me!
|
|
||
| <scheme>mmm_physics_compat</scheme> | ||
|
|
||
| <!-- Begin section RRTMGP --> |
There was a problem hiding this comment.
I might note here that RRTMGP is the radiation scheme (as it may not be obvious to new users):
| <!-- Begin section RRTMGP --> | |
| <!-- Begin section RRTMGP (radiation scheme) --> |
| ! Save pending tendencies to final tendencies. | ||
| ! | ||
| ! The reason for this mechanism is to mitigate the inconsistent tendency behaviors across various MMM physics schemes. | ||
| ! Although some schemes correctly accumulate their tendencies with others, there are certain schemes that outright | ||
| ! overwrite the tendencies from others. Instead of wrestling with the problematic schemes individually like MPAS does, | ||
| ! which is very error-prone, a suite-level scheme is introduced to blanketly enforce the correct behavior. |
There was a problem hiding this comment.
I'm totally happy with this for now, but long-term is there a chance that we can eventually fix the problematic schemes so that this helper scheme is no longer needed? Definitely not a high priority, but it does seem like a way to reduce the total amount of variables (and thus memory) that is needed for a simulation.
There was a problem hiding this comment.
I can definitely move the fixes to the compatibility wrapper of each scheme if that is the desired direction, but we likely cannot modify the main schemes at MMM-physics because it will break the dependent MMM models.
MPAS also suffers from this issue: The _p-suffix variables can be found all over the place in each physics driver (e.g., the PBL physics driver[1]).
peverwhee
left a comment
There was a problem hiding this comment.
one tiny comment quibble but nothing that holds back my approval!
Tag name
None (Bit-for-bit)
Originator(s)
kuanchihwang
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number)
This PR adds RRTMGP and surface coupling to the convection-permitting suite. It also applies a blanket fix to the inconsistent tendency handling across various MMM physics schemes.
List all namelist files that have been modified
None
List all files eliminated and why
None
List all files added and what they do
None
List all existing files that have been modified, and describe the changes
List all automated tests that failed, as well as an explanation for why they were not fixed
All passed.
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
Yes, but only for the convection-permitting suite.
If yes to the above question, describe how this code was validated with the new/modified features
Configure, build, and run CAM-SIMA with the
MPASCPcompset.