Skip to content

Add support for CO2 emissions compsets with CAM7 #4068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
klindsay28 wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −0
Draft

Add support for CO2 emissions compsets with CAM7 #4068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cime_config/config_component.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ Caveats:
<default_value>constant</default_value>
<values>
<value compset="_CAM" >diagnostic</value>
<value compset="E_CAM70" >prognostic</value>

@ekluzek ekluzek Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will trigger for any compset with an "E" on the end of the timeperiod. This will function for the convention where C or E can be given after the timeperiod. But, this isn't a very robust way to define it, since the timeperiod and the CO2 type are unrelated. The mechanism we still have in place with _BGC that you see below is more clear. But, it has the problem of being confused with the BGC setting being used for CLM (i.e. CLM60%BGC). The difference between BDRD and BPRP is also not clear below either which is part of the reason for the "C" vs. "E" convention. But, it's even less clear.

So one proposal was to have something like:

_CO2%CONC and _CO2%EMIS

which is much clearer. One problem is that we have to make the change for all components. But, the "E_CAM70" proposal requires the same, and is really not very clear at all.

@ekluzek ekluzek Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it more, this also will ONLY work if the longcompset name has E_CAM70. So Emissions compsets that aren't using CAM70 will silently do the wrong thing and end up being concentration driven. If we go with the "E" at the end of the timeperiod to specify concentration or emissions, we need a way to make sure it isn't just being silently ignored.

This isn't really a problem with what's proposed here, as much as it's a problem with compsets in general. We really need ways to do error checking to make sure they work like they should. That's a more general problem.

@billsacks billsacks Jun 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really a problem with what's proposed here, as much as it's a problem with compsets in general. We really need ways to do error checking to make sure they work like they should. That's a more general problem.

Agreed. See ESMCI/cime#3816 - but I have no idea when I or others will get time to tackle this.

<value compset="_BGC%BDRD" >diagnostic</value>
<value compset="_BGC%BPRP" >prognostic</value>
<value compset="HIST.*_DATM" >diagnostic</value>
Expand Down
Loading