-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctsm5.3.028: Move Izumi intel and gnu tests to Derecho #2975
ctsm5.3.028: Move Izumi intel and gnu tests to Derecho #2975
Conversation
Those two Python scripts could actually be used in a GitHub workflow to check that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that the new testlist only has izumi_nag. And the changes all make sense to me. Some things I hadn't thought about you also brought in which makes sense. This will make the test list on Derecho, slightly longer, but that's fine.
I also think that the tools you made should become more mainstream. The tmp directory makes me think you were going to delete them. But, I don't think you should. We should do more of using tools like this. If they do become more mainstream, I'd like to see more testing for them, and probably a library level that removes some code duplication.
But, I think you bring this in like it is.
Migrate FATES parameter file switches to the namelist
Description of changes
Moves Izumi intel and gnu tests to Derecho.
Remaining work:
Notes to reviewer(s)
tools/contrib/remove_duplicate_tests.py
, removes duplicate tests resulting from the Izumi-to-Derecho change. It also removes any extraneous whitespace fromtestlist_clm.xml
.Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed:
Are answers expected to change (and if so in what way)? No. However, a bunch of tests will be moved from Izumi to Derecho.
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
aux_clm
passes except expected failures.