-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "Bytnerowicz" the default nfix_method for clm6 #2972
Conversation
derecho testing
In aux_clm, expect DIFF for clm6 only, I think. UPDATE |
derecho testing
I used izumi testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave my two cents in some of the conversations.
I also request one change, to the namelist_defintion file, but still marking as approve, so you don't have to have me reapprove.
I also move this out of draft state, as it looks like it's ready, unless you find problems in testing.
I'm requesting another set of eyes on the ChangeLog, though I will proceed with the merge regardless, when izumi testing is complete some time tomorrow probably. |
Make "Bytnerowicz" the default nfix_method for clm6 Update paramfile and finidat accordingly. ./rimport new files as needed to resolve izumi aux_clm failures. PR ESCOMP#2972 issue ESCOMP#1339 slevis resolved conflicts: cime_config/testdefs/testlist_clm.xml doc/ChangeLog doc/ChangeSum
Description of changes
Same as PR's title, plus update paramfile and finidat accordingly.
Definition of DONE checklist in the issue.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Fixes #1339
Are answers expected to change (and if so in what way)?
Yes, greater than roundoff, same climate.
Any User Interface Changes (namelist or namelist defaults changes)?
See Description of changes above.
Does this create a need to change or add documentation? Did you do so?
Likely, but not done.
Testing performed, if any:
None, yet.