Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Bytnerowicz" the default nfix_method for clm6 #2972

Merged
merged 9 commits into from
Mar 5, 2025

Conversation

slevis-lmwg
Copy link
Contributor

Description of changes

Same as PR's title, plus update paramfile and finidat accordingly.

Definition of DONE checklist in the issue.

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):
Fixes #1339

Are answers expected to change (and if so in what way)?
Yes, greater than roundoff, same climate.

Any User Interface Changes (namelist or namelist defaults changes)?
See Description of changes above.

Does this create a need to change or add documentation? Did you do so?
Likely, but not done.

Testing performed, if any:
None, yet.

@slevis-lmwg slevis-lmwg self-assigned this Feb 21, 2025
@slevis-lmwg slevis-lmwg added the non-bfb Changes answers (incl. adding tests) label Feb 21, 2025
@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Feb 22, 2025

derecho testing

PASS make black and lint (not necessary)
PASS python (not necessary)
PASS ./build-namelist_test.pl
OK ./run_sys_tests -s aux_clm -c ctsm5.3.025 --skip-generate

In aux_clm, expect DIFF for clm6 only, I think.

UPDATE
In /glade/derecho/scratch/slevis/tests_0221-165928de using
./cs.status.fails | grep -v PASS | grep -v NLCOMP | grep -v '025: DIF'
shows expected fails.

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Mar 4, 2025

derecho testing

PASS ./build-namelist_test.pl
OK ./run_sys_tests -s aux_clm -c ctsm5.3.028 -g ctsm5.3.029

I used
./cs.status.fails | grep -i fate | grep -v NLCOM | grep -v PASS
to confirm that Fates cases do not differ from the baseline and
./cs.status.fails | grep '028: DIF'|grep -v Clm6
to confirm that only Clm6 cases differ from the baseline.

izumi testing
OK ./run_sys_tests -s aux_clm -c ctsm5.3.028 -g ctsm5.3.029
Repeated above confirmations on izumi, as well.

@ekluzek ekluzek marked this pull request as ready for review March 4, 2025 18:42
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave my two cents in some of the conversations.

I also request one change, to the namelist_defintion file, but still marking as approve, so you don't have to have me reapprove.

I also move this out of draft state, as it looks like it's ready, unless you find problems in testing.

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Mar 5, 2025

I'm requesting another set of eyes on the ChangeLog, though I will proceed with the merge regardless, when izumi testing is complete some time tomorrow probably.

@slevis-lmwg slevis-lmwg merged commit be65fad into ESCOMP:master Mar 5, 2025
2 checks passed
@slevis-lmwg slevis-lmwg deleted the bnf_default branch March 5, 2025 16:48
slevis-lmwg added a commit to slevis-lmwg/ctsm that referenced this pull request Mar 5, 2025
Make "Bytnerowicz" the default nfix_method for clm6

Update paramfile and finidat accordingly.
./rimport new files as needed to resolve izumi aux_clm failures.

PR ESCOMP#2972
issue ESCOMP#1339

slevis resolved conflicts:
cime_config/testdefs/testlist_clm.xml
doc/ChangeLog
doc/ChangeSum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-bfb Changes answers (incl. adding tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternative cost functions in FUN
3 participants