Sync w/ latest UFS changes#659
Merged
Merged
Conversation
* update typedefs for icplocn2atm * update standard_name in ccpp/data
* add u,v ocn->atm for global configs * update typedefs for icplocn2atm
* Replace horizontal_loop_extent with horizontal_dimension * One more CCPP metadata change
* update Sa_pslv to be bilinear * change coupling mode for bulk aoflux scheme consistent w/ mapping * minor tweaks to aoflux module for clarity
* purge hafs only related code, swap remaining mode name to hafs, not hafs.mom6
… names to match feature/tendency_cleanup branch (NOAA-EMC#161)
billsacks
approved these changes
Jun 3, 2026
billsacks
left a comment
billsacks
left a comment
Member
There was a problem hiding this comment.
This looks good to me. I have reviewed the modules that apply to CESM; I haven't looked at modules that apply only to UFS.
@DeniseWorthen do you feel this warrants a review from anyone else?
@fischer-ncar - although this looks safe to me, it's worth keeping an extra eye on the nightly baseline tests after this is merged to verify that this passes all tests and is bit-for-bit.
Collaborator
Author
|
@billsacks Thanks for reviewing. In this case, I don't think needs additional review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds recent changes for CMEPS in UFS
Specific notes
Adds ufs_trace wrapper to enable profiling for use in UFS.
Adds capability to use mapfiles in UFS global applications.
Removes HYCOM field exchanges in UFS/HAFS mode (HYCOM has been removed from our component list).
Removes deprecated flux scheme for UFS (ocean_flux_scheme == -1)
Updates ufs/ccpp as required for ccpp changes
Contributors other than yourself, if any:
ufs_tracing capability was developed by @DusanJovic-NOAA
Changes should not touch any CESM code and should be B4B.