Skip to content

cam6_4_184: Complete CCPPization of Beljaars orographic form drag scheme; cleanup#1558

Open
jimmielin wants to merge 6 commits into
ESCOMP:cam_developmentfrom
jimmielin:hplin/beljaars
Open

cam6_4_184: Complete CCPPization of Beljaars orographic form drag scheme; cleanup#1558
jimmielin wants to merge 6 commits into
ESCOMP:cam_developmentfrom
jimmielin:hplin/beljaars

Conversation

@jimmielin

@jimmielin jimmielin commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #1555

Companion atmos_phys PR: ESCOMP/atmospheric_physics#396
all the logic has been moved to atmos_phys.

M       bld/configure
  - add atmos_phys/schemes/beljaars_drag directory to build directories

D       src/physics/cam/beljaars_drag.F90
  - moved to atmos_phys and cleaned up.

M       src/physics/cam/beljaars_drag_cam.F90
  - clean up unused, call CCPPized subroutine

M       src/physics/cam/physpkg.F90
M       src/physics/cam7/physpkg.F90
  - removed unused cam_in argument to beljaars_drag_tend

@jimmielin jimmielin self-assigned this May 14, 2026
@jimmielin jimmielin added BFB bit for bit tag ccpp-conversion labels May 14, 2026
JulioTBacmeister
JulioTBacmeister approved these changes Jun 4, 2026
View reviewed changes

@JulioTBacmeister JulioTBacmeister left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

cacraigucar
cacraigucar requested changes Jun 16, 2026
View reviewed changes

@cacraigucar cacraigucar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A reminder for me: Need to update the atmospheric_physics external

@jimmielin jimmielin requested a review from cacraigucar June 23, 2026 18:11
@jimmielin

jimmielin commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

Thanks @cacraigucar, updated to the official atmos_phys tag (0_24_000) and this is ready for tagging.

@cacraigucar cacraigucar changed the title Complete CCPPization of Beljaars orographic form drag scheme; cleanup cam6_4_184: Complete CCPPization of Beljaars orographic form drag scheme; cleanup Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cacraigucar cacraigucar cacraigucar approved these changes

+1 more reviewer

@JulioTBacmeister JulioTBacmeister JulioTBacmeister approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jimmielin jimmielin

Labels

BFB bit for bit tag ccpp-conversion

Projects

CAM Development
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jimmielin @JulioTBacmeister @cacraigucar