Skip to content

Add topography_statics_read host-side module to read topography dataset.#529

Open
jimmielin wants to merge 2 commits into
ESCOMP:developmentfrom
jimmielin:hplin/topography_statics_read
Open

Add topography_statics_read host-side module to read topography dataset.#529
jimmielin wants to merge 2 commits into
ESCOMP:developmentfrom
jimmielin:hplin/topography_statics_read

Conversation

@jimmielin

Copy link
Copy Markdown
Collaborator

Tag name (required for release branches):
Originator(s): @jimmielin
AI tools used (if applicable; please also add the "AI-generated code" label to the PR):
What: claude-fable:5
How: wrote the initial version of the scheme.

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

  • Add topography_statics_read to do a decomposed read (so it cannot be a CCPP scheme) of SGH, SGH30, LANDM_COSLAT

Describe any changes made to build system:

Describe any changes made to the namelist:

List any changes to the defaults for the input datasets (e.g. boundary datasets):

List all files eliminated and why:

List all files added and what they do:

A       src/physics/utils/topography_statics_read.F90
  - new host-side read module

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M       src/control/cam_comp.F90
  - call new topography_statics_read

M       src/data/registry.xml
  - move the topo fields to the top of the file away from "temporary initializations"
    although their standard names might still need some work (SGH, SGH30)

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima:

derecho/gnu/aux_sima:

derecho/nvhpc/aux_sima (test is run via Github workflow. Only run the test manually if we need to save new baselines):

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

@jimmielin
jimmielin requested a review from cacraigucar July 22, 2026 20:33
@jimmielin jimmielin self-assigned this Jul 22, 2026
@jimmielin jimmielin added enhancement New feature or request AI-generated code labels Jul 22, 2026
@jimmielin
jimmielin requested a deployment to CI-tests-on-CIRRUS July 22, 2026 20:33 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-generated code enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant