sima0_15_000: Complete CCPPization of CAM5 UW PBL scheme (diag_TKE)

[jimmielin]

Tag name (required for release branches): sima0_15_000
Originator(s): @jimmielin

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

• Completes CCPPization of CAM5 UW PBL scheme.

Describe any changes made to build system: N/A

Describe any changes made to the namelist: N/A

List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A

List all files eliminated and why: N/A

List all files added and what they do:

A       cime_config/testdefs/testmods_dirs/cam/outfrq_uw_vdiff_derecho/shell_commands
A       cime_config/testdefs/testmods_dirs/cam/outfrq_uw_vdiff_derecho/user_nl_cam
  - add new uw_vdiff test for derecho/gnu

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M       cime_config/testdefs/testlist_cam.xml
  - add new uw_vdiff test for derecho/gnu (snapshot test)

M       src/dynamics/none/stepon.F90
  - override is_first_timestep to always false, since CAM snapshots never write out
    the first timestep.

M       src/control/cam_comp.F90
  - move stepon_timestep_init to after MUSICA temporary initialization, since
    stepon_timestep_init in null dycore will set is_first_timestep to false but
    MUSICA initialization needs to know the "true" first timestep state.

M       src/data/registry.xml
  - add registry variables for UW PBL

M       src/physics/utils/physics_data.F90
  - also try cnst_ prefix when reading constituent-dimensioned variables

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima:

  SMS_Ln9.ne3pg3_ne3pg3_mg37.FKESSLER.derecho_intel.cam-outfrq_se_cslam_multitape (Overall: NLFAIL) details:
    FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.FKESSLER.derecho_intel.cam-outfrq_se_cslam_multitape NLCOMP
  - pre-existing failure

derecho/gnu/aux_sima:

  SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_hb_vdiff_derecho (Overall: DIFF) details:
    FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_hb_vdiff_derecho NLCOMP
    FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_hb_vdiff_derecho BASELINE /glade/campaign/cesm/community/amwg/sima_baselines/latest_gnu: DIFF
  - updated snapshot file to match cam6_4_179.

  SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_uw_vdiff_derecho (Overall: DIFF) details:
    FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_uw_vdiff_derecho NLCOMP
    FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_uw_vdiff_derecho BASELINE /glade/campaign/cesm/community/amwg/sima_baselines/latest_gnu: ERROR BFAIL baseline directory '/glade/campaign/cesm/community/amwg/sima_baselines/latest_gnu/SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_uw_vdiff_derecho' does not exist
  - new test.

  SMS_Ln9.ne3pg3_ne3pg3_mg37.FADIAB.derecho_gnu.cam-outfrq_se_cslam (Overall: FAIL) details:
    FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.FADIAB.derecho_gnu.cam-outfrq_se_cslam RUN time=13
  - pre-existing failure.

derecho/nvhpc/aux_sima: All PASS

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

[nusbaume]

Thanks @jimmielin! I had one request related to setting the first timestep flag, but otherwise everything looks good to me!

[nusbaume]

Instead of always setting this to .false., I wonder if we should just see if ncdata_check is set to .true., and if so then is_first_timestep is .false., otherwise it is .true.. The reason is because I can imagine that the null dycore will eventually be used for "real" scientific analyses beyond just snapshot testing (e.g. in a single-column model configuration), in which case we probably won't want this to be set to .false..

[jimmielin]

Thanks @nusbaume, I applied a ncdata_check guard as suggested in a0a3bc6.