Skip to content

Properly support trailing comma in char namelist entries in atm_in_paramgen - #423

Merged
jimmielin merged 5 commits into
ESCOMP:developmentfrom
jimmielin:hplin/trailing_comma_nl
Oct 23, 2025
Merged

Properly support trailing comma in char namelist entries in atm_in_paramgen#423
jimmielin merged 5 commits into
ESCOMP:developmentfrom
jimmielin:hplin/trailing_comma_nl

Conversation

@jimmielin

Copy link
Copy Markdown
Collaborator

Tag name (required for release branches):
Originator(s): @jimmielin

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

Describe any changes made to build system:
atm_in_paramgen updated to support this. Doctests added to cover this case.

Describe any changes made to the namelist: N/A

List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A

List all files eliminated and why: N/A

List all files added and what they do: N/A

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)
M cime_config/atm_in_paramgen.py

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima:

derecho/gnu/aux_sima:

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

@nusbaume nusbaume left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimmielin! I just had two small change requests.

Comment thread cime_config/atm_in_paramgen.py Outdated
Comment thread cime_config/atm_in_paramgen.py Outdated
jimmielin and others added 2 commits September 12, 2025 17:38
Co-authored-by: Jesse Nusbaumer <nusbaume@ucar.edu>
Co-authored-by: Jesse Nusbaumer <nusbaume@ucar.edu>
@jimmielin
jimmielin requested a review from nusbaume September 12, 2025 21:39
@jimmielin

Copy link
Copy Markdown
Collaborator Author

Thanks @nusbaume! I've committed in your suggested changes, this should be ready once the tests finish run and pass.

@jimmielin
jimmielin requested a review from peverwhee September 12, 2025 21:39

@nusbaume nusbaume left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing my change requests!

@jimmielin
jimmielin merged commit 1bdc129 into ESCOMP:development Oct 23, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants