Skip to content

Fix crash in physics_check_data when registry variable has initial_value but not read from file, yet is modified (intent out) from physics scheme #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimmielin merged 4 commits into from
Sep 29, 2025
Merged

Fix crash in physics_check_data when registry variable has initial_value but not read from file, yet is modified (intent out) from physics scheme #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ebdd28
Fix crash in physics_check_data when registry variable has initial_va…
hplin-ucar Aug 27, 2025
ecb38b6
Update sample files
hplin-ucar Sep 26, 2025
19e954f
Add missing periods at end of sentence
hplin-ucar Sep 26, 2025
99dc62a
Merge branch 'development' into hplin/intent_out_check_bugfix
hplin-ucar Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/data/write_init_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,7 +1099,7 @@ def write_phys_read_subroutine(outfile, host_dict, host_vars, host_imports,
# Handle the case where the required variable is a constituent
outfile.write("case (const_idx)", 5)
outfile.blank_line()
outfile.comment("If an index was found in the constituent hash table, then do nothing, this will be handled later", 6)
outfile.comment("If an index was found in the constituent hash table, then do nothing, this will be handled later.", 6)
outfile.blank_line()

# start default case steps:
Expand Down Expand Up @@ -1412,7 +1412,13 @@ def write_phys_check_subroutine(outfile, host_dict, host_vars, host_imports,
# Skip constituent variables:
outfile.write("case (const_idx)", 5)
outfile.blank_line()
outfile.comment("If variable is a constituent, then do nothing. We'll handle these later", 6)
outfile.comment("If variable is a constituent, then do nothing. We'll handle these later.", 6)
outfile.blank_line()

# Skip already initialized variables:
outfile.write("case (init_mark_idx)", 5)
outfile.blank_line()
outfile.comment("If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. There is nothing we can check against.", 6)
outfile.blank_line()

# Generate error message if required variable isn't found:
Expand Down
9 changes: 7 additions & 2 deletions test/unit/python/sample_files/write_init_files/physics_inputs_4D.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia

case (const_idx)

! If an index was found in the constituent hash table, then do nothing, this will be handled later
! If an index was found in the constituent hash table, then do nothing, this will be handled later.

case default

Expand Down Expand Up @@ -317,7 +317,12 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference,

case (const_idx)

! If variable is a constituent, then do nothing. We'll handle these later
! If variable is a constituent, then do nothing. We'll handle these later.

case (init_mark_idx)

! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme.
! There is nothing we can check against.

case (no_exist_idx)

Expand Down
9 changes: 7 additions & 2 deletions test/unit/python/sample_files/write_init_files/physics_inputs_bvd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia

case (const_idx)

! If an index was found in the constituent hash table, then do nothing, this will be handled later
! If an index was found in the constituent hash table, then do nothing, this will be handled later.

case default

Expand Down Expand Up @@ -317,7 +317,12 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference,

case (const_idx)

! If variable is a constituent, then do nothing. We'll handle these later
! If variable is a constituent, then do nothing. We'll handle these later.

case (init_mark_idx)

! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme.
! There is nothing we can check against.

case (no_exist_idx)

Expand Down
9 changes: 7 additions & 2 deletions test/unit/python/sample_files/write_init_files/physics_inputs_cnst.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia

case (const_idx)

! If an index was found in the constituent hash table, then do nothing, this will be handled later
! If an index was found in the constituent hash table, then do nothing, this will be handled later.

case default

Expand Down Expand Up @@ -317,7 +317,12 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference,

case (const_idx)

! If variable is a constituent, then do nothing. We'll handle these later
! If variable is a constituent, then do nothing. We'll handle these later.

case (init_mark_idx)

! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme.
! There is nothing we can check against.

case (no_exist_idx)

Expand Down
9 changes: 7 additions & 2 deletions test/unit/python/sample_files/write_init_files/physics_inputs_constituent_dim.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia

case (const_idx)

! If an index was found in the constituent hash table, then do nothing, this will be handled later
! If an index was found in the constituent hash table, then do nothing, this will be handled later.

case default

Expand Down Expand Up @@ -325,7 +325,12 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference,

case (const_idx)

! If variable is a constituent, then do nothing. We'll handle these later
! If variable is a constituent, then do nothing. We'll handle these later.

case (init_mark_idx)

! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme.
! There is nothing we can check against.

case (no_exist_idx)

Expand Down
9 changes: 7 additions & 2 deletions test/unit/python/sample_files/write_init_files/physics_inputs_ddt.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia

case (const_idx)

! If an index was found in the constituent hash table, then do nothing, this will be handled later
! If an index was found in the constituent hash table, then do nothing, this will be handled later.

case default

Expand Down Expand Up @@ -317,7 +317,12 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference,

case (const_idx)

! If variable is a constituent, then do nothing. We'll handle these later
! If variable is a constituent, then do nothing. We'll handle these later.

case (init_mark_idx)

! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme.
! There is nothing we can check against.

case (no_exist_idx)

Expand Down
9 changes: 7 additions & 2 deletions test/unit/python/sample_files/write_init_files/physics_inputs_ddt2.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia

case (const_idx)

! If an index was found in the constituent hash table, then do nothing, this will be handled later
! If an index was found in the constituent hash table, then do nothing, this will be handled later.

case default

Expand Down Expand Up @@ -317,7 +317,12 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference,

case (const_idx)

! If variable is a constituent, then do nothing. We'll handle these later
! If variable is a constituent, then do nothing. We'll handle these later.

case (init_mark_idx)

! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme.
! There is nothing we can check against.

case (no_exist_idx)

Expand Down
9 changes: 7 additions & 2 deletions test/unit/python/sample_files/write_init_files/physics_inputs_ddt_array.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia

case (const_idx)

! If an index was found in the constituent hash table, then do nothing, this will be handled later
! If an index was found in the constituent hash table, then do nothing, this will be handled later.

case default

Expand Down Expand Up @@ -317,7 +317,12 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference,

case (const_idx)

! If variable is a constituent, then do nothing. We'll handle these later
! If variable is a constituent, then do nothing. We'll handle these later.

case (init_mark_idx)

! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme.
! There is nothing we can check against.

case (no_exist_idx)

Expand Down
9 changes: 7 additions & 2 deletions test/unit/python/sample_files/write_init_files/physics_inputs_host_var.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia

case (const_idx)

! If an index was found in the constituent hash table, then do nothing, this will be handled later
! If an index was found in the constituent hash table, then do nothing, this will be handled later.

case default

Expand Down Expand Up @@ -313,7 +313,12 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference,

case (const_idx)

! If variable is a constituent, then do nothing. We'll handle these later
! If variable is a constituent, then do nothing. We'll handle these later.

case (init_mark_idx)

! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme.
! There is nothing we can check against.

case (no_exist_idx)

Expand Down
9 changes: 7 additions & 2 deletions test/unit/python/sample_files/write_init_files/physics_inputs_initial_value.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia

case (const_idx)

! If an index was found in the constituent hash table, then do nothing, this will be handled later
! If an index was found in the constituent hash table, then do nothing, this will be handled later.

case default

Expand Down Expand Up @@ -317,7 +317,12 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference,

case (const_idx)

! If variable is a constituent, then do nothing. We'll handle these later
! If variable is a constituent, then do nothing. We'll handle these later.

case (init_mark_idx)

! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme.
! There is nothing we can check against.

case (no_exist_idx)

Expand Down
9 changes: 7 additions & 2 deletions test/unit/python/sample_files/write_init_files/physics_inputs_mf.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia

case (const_idx)

! If an index was found in the constituent hash table, then do nothing, this will be handled later
! If an index was found in the constituent hash table, then do nothing, this will be handled later.

case default

Expand Down Expand Up @@ -318,7 +318,12 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference,

case (const_idx)

! If variable is a constituent, then do nothing. We'll handle these later
! If variable is a constituent, then do nothing. We'll handle these later.

case (init_mark_idx)

! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme.
! There is nothing we can check against.

case (no_exist_idx)

Expand Down
9 changes: 7 additions & 2 deletions test/unit/python/sample_files/write_init_files/physics_inputs_no_horiz.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia

case (const_idx)

! If an index was found in the constituent hash table, then do nothing, this will be handled later
! If an index was found in the constituent hash table, then do nothing, this will be handled later.

case default

Expand Down Expand Up @@ -317,7 +317,12 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference,

case (const_idx)

! If variable is a constituent, then do nothing. We'll handle these later
! If variable is a constituent, then do nothing. We'll handle these later.

case (init_mark_idx)

! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme.
! There is nothing we can check against.

case (no_exist_idx)

Expand Down
9 changes: 7 additions & 2 deletions test/unit/python/sample_files/write_init_files/physics_inputs_noreq.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia

case (const_idx)

! If an index was found in the constituent hash table, then do nothing, this will be handled later
! If an index was found in the constituent hash table, then do nothing, this will be handled later.

case default

Expand Down Expand Up @@ -309,7 +309,12 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference,

case (const_idx)

! If variable is a constituent, then do nothing. We'll handle these later
! If variable is a constituent, then do nothing. We'll handle these later.

case (init_mark_idx)

! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme.
! There is nothing we can check against.

case (no_exist_idx)

Expand Down
9 changes: 7 additions & 2 deletions test/unit/python/sample_files/write_init_files/physics_inputs_param.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia

case (const_idx)

! If an index was found in the constituent hash table, then do nothing, this will be handled later
! If an index was found in the constituent hash table, then do nothing, this will be handled later.

case default

Expand Down Expand Up @@ -320,7 +320,12 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference,

case (const_idx)

! If variable is a constituent, then do nothing. We'll handle these later
! If variable is a constituent, then do nothing. We'll handle these later.

case (init_mark_idx)

! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme.
! There is nothing we can check against.

case (no_exist_idx)

Expand Down
9 changes: 7 additions & 2 deletions test/unit/python/sample_files/write_init_files/physics_inputs_protect.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia

case (const_idx)

! If an index was found in the constituent hash table, then do nothing, this will be handled later
! If an index was found in the constituent hash table, then do nothing, this will be handled later.

case default

Expand Down Expand Up @@ -317,7 +317,12 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference,

case (const_idx)

! If variable is a constituent, then do nothing. We'll handle these later
! If variable is a constituent, then do nothing. We'll handle these later.

case (init_mark_idx)

! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme.
! There is nothing we can check against.

case (no_exist_idx)

Expand Down
9 changes: 7 additions & 2 deletions test/unit/python/sample_files/write_init_files/physics_inputs_scalar.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia

case (const_idx)

! If an index was found in the constituent hash table, then do nothing, this will be handled later
! If an index was found in the constituent hash table, then do nothing, this will be handled later.

case default

Expand Down Expand Up @@ -317,7 +317,12 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference,

case (const_idx)

! If variable is a constituent, then do nothing. We'll handle these later
! If variable is a constituent, then do nothing. We'll handle these later.

case (init_mark_idx)

! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme.
! There is nothing we can check against.

case (no_exist_idx)

Expand Down
9 changes: 7 additions & 2 deletions test/unit/python/sample_files/write_init_files/physics_inputs_simple.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia

case (const_idx)

! If an index was found in the constituent hash table, then do nothing, this will be handled later
! If an index was found in the constituent hash table, then do nothing, this will be handled later.

case default

Expand Down Expand Up @@ -317,7 +317,12 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference,

case (const_idx)

! If variable is a constituent, then do nothing. We'll handle these later
! If variable is a constituent, then do nothing. We'll handle these later.

case (init_mark_idx)

! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme.
! There is nothing we can check against.

case (no_exist_idx)

Expand Down