Skip to content

PIO reader variable subsetting functionality #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nusbaume merged 59 commits into from
Oct 2, 2025
Merged

PIO reader variable subsetting functionality #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
586a05f
Add 'var_subset_check' helper routine, with initial 'both present' ch…
nusbaume Aug 5, 2025
d7b4bbe
Add missing subroutine arguments.
nusbaume Aug 5, 2025
63a5cbb
Add check for correct 'start' size, along with new unit test.
nusbaume Aug 6, 2025
de58bea
Add missing 'count' entry to test.
nusbaume Aug 6, 2025
eaf9264
Add missing space to error message, a 'count' size check, and an asso…
nusbaume Aug 6, 2025
f01ec4d
Add check and test for ensuring that start elements are within range.
nusbaume Aug 8, 2025
098f4a0
Add missing Fortran character format.
nusbaume Aug 8, 2025
bd07e62
Add 'alloc_dims' output variable to ensure output variable is allocat…
nusbaume Aug 8, 2025
bf91195
Remove un-needed dimension index from allocate call.
nusbaume Aug 8, 2025
bc91c13
Add bounds checking for 'count' optional variable.
nusbaume Aug 8, 2025
58a4840
Fix syntax error.
nusbaume Aug 8, 2025
e9018c3
Add subsetting when shape(count) matches shape(var), including unit t…
nusbaume Aug 13, 2025
61389fd
Fix typo in subroutine call.
nusbaume Aug 13, 2025
ee4a3e9
Fix 'do_subset' syntax error.
nusbaume Aug 13, 2025
249f87a
Fix bad subroutine name.
nusbaume Aug 13, 2025
c47dbe6
Flip error message and error code check for subset read test.
nusbaume Aug 13, 2025
5175ea3
Add debugging output.
nusbaume Aug 13, 2025
a45e9d2
Cleanup debug output and modify start/count element range checks.
nusbaume Aug 13, 2025
53780e7
Add subsetting to 2-D integer interface, add unit test, fix bad unit …
nusbaume Aug 13, 2025
41fcd3d
Add 'singe value' subset test, and fix bad error message.
nusbaume Aug 13, 2025
640a440
remove extraneous sum calls.
nusbaume Aug 13, 2025
5c48075
Move non-subsetting rank check to 'var_subset_check', and add additio…
nusbaume Aug 14, 2025
d6fc649
Remove use of 'count' intrinsic to avoid name collision.
nusbaume Aug 14, 2025
de647be
Fix bad syntax in error message.
nusbaume Aug 14, 2025
3385d54
Add subsetting calls to all non-scalar get_var calls.
nusbaume Aug 14, 2025
76fc32a
Fix syntax error.
nusbaume Aug 14, 2025
ee27eb3
Adjust 'var_ndims' for charactervariables.
nusbaume Aug 14, 2025
0c85688
Remove extra space in expected error message.
nusbaume Aug 15, 2025
dbc7354
Change error message text, and add additional unit tests.
nusbaume Aug 15, 2025
ac6fce9
Fix use statements in pFUnit Fortran code.
nusbaume Aug 16, 2025
6f184f2
Move count bounds checking outside of output var check, and fix test …
nusbaume Aug 16, 2025
73b75a3
Comment out real var subsetting test.
nusbaume Aug 16, 2025
59775cc
Fix bad subsetting test, and partially uncomment 1D real subset test.
nusbaume Aug 16, 2025
5b331ba
Uncomment 'end subroutine' line.
nusbaume Aug 16, 2025
6402882
Remove comma from expected error message, and try reading press_ref v…
nusbaume Aug 16, 2025
ef23f22
Try 1D real subset test again.
nusbaume Aug 16, 2025
e829e94
Add 'pio_get_var' subsetting to remaining multi-dim get_var interfaces.
nusbaume Aug 18, 2025
2776f7c
Print out press_ref values and change order.
nusbaume Aug 18, 2025
574e71e
Change write statement to see if that fixes build issue?
nusbaume Aug 18, 2025
4add51e
Removed commented-out assert statement.
nusbaume Aug 18, 2025
dfa8143
Add back-in original 'assert' statement.
nusbaume Aug 18, 2025
23f6459
Formally declare expected values in real 1D subset test.
nusbaume Aug 18, 2025
72844d0
Add ability to reduce output variable dimensionality via subsetting. …
nusbaume Aug 19, 2025
a20f592
Make output variable 3D to see if that works.
nusbaume Aug 19, 2025
4f91699
Remove variable dimension reduction functionality (it doesn't appear …
nusbaume Aug 22, 2025
c2ff44c
Add error if user tries to subset a scalar variable, along with a rel…
nusbaume Aug 22, 2025
77d876d
Add character variable subsetting unit test.
nusbaume Aug 22, 2025
1625101
Fix character size assert check in subsetting test.
nusbaume Aug 22, 2025
da268b0
Fix syntax error in subset test.
nusbaume Aug 22, 2025
37f1dd5
Add debugging output.
nusbaume Aug 22, 2025
9cee38d
Try subsetting with character array length provided.
nusbaume Aug 22, 2025
1728712
Increase 'var_ndims' by one to avoid incorrect error.
nusbaume Aug 22, 2025
dc0e3dc
Fix unit test assert statements, and update remaining character get_v…
nusbaume Aug 22, 2025
ab49b90
Fix error message in unit test.
nusbaume Aug 22, 2025
0e5fb36
Remove fork/branch from Github Actions workflow.
nusbaume Aug 25, 2025
f65ec49
Remove leftover debugging code.
nusbaume Aug 25, 2025
7edfd56
Fix bugs found during code review (with additional test).
nusbaume Sep 12, 2025
cb365ed
Fix unit test error message.
nusbaume Sep 12, 2025
2e3be79
Merge remote-tracking branch 'upstream/development' into pio_reader_s…
nusbaume Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading