Skip to content

Refactor MPAS dynamical core in preparation for unit testing #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kuanchihwang merged 18 commits into from
Aug 13, 2025
Merged

Refactor MPAS dynamical core in preparation for unit testing #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4eb40af
Separate interfaces and implementations by using Fortran submodules
kuanchihwang-ncar Jul 9, 2025
01a7d1d
Separate interfaces and implementations by using Fortran submodules
kuanchihwang-ncar Jul 9, 2025
d148c6a
Move subroutines to the modules that make more contextual sense
kuanchihwang-ncar Jul 8, 2025
24dbe36
Update code comments
kuanchihwang-ncar Jul 12, 2025
2c69c06
Workaround to help the mkDepends tool in CIME find build dependencies
kuanchihwang-ncar Jul 15, 2025
7dc4408
Refactor in preparation for unit testing
kuanchihwang-ncar Jul 10, 2025
fb5bf45
Refactor in preparation for unit testing
kuanchihwang-ncar Jul 16, 2025
ed50c4d
Refactor dyn_init for better readability
kuanchihwang-ncar Jul 18, 2025
4c8bbc5
Merge branch 'development' into develop/mpas-dycore-refactor
kuanchihwang-ncar Aug 4, 2025
faa07d6
Fix a code style issue introduced from upstream
kuanchihwang-ncar Aug 4, 2025
888e1c5
Merge branch 'development' into develop/mpas-dycore-refactor
kuanchihwang-ncar Aug 6, 2025
6c006f9
Revert "Workaround to help the mkDepends tool in CIME find build depe…
kuanchihwang-ncar Aug 6, 2025
8da9556
Remove unnecessary `contains` statements
kuanchihwang-ncar Aug 6, 2025
14876ba
Update code comments for `index_unique`
kuanchihwang-ncar Aug 6, 2025
217473c
Clarify the difference between the `dyn_{,mpas_}procedure` modules
kuanchihwang-ncar Aug 6, 2025
f22aef2
Rename module names to `dyn_{,mpas_}procedures`
kuanchihwang-ncar Aug 6, 2025
6cb6097
Rename file names to `dyn_{,mpas_}procedures.F90`
kuanchihwang-ncar Aug 6, 2025
0d81f21
Merge branch 'development' into develop/mpas-dycore-refactor
kuanchihwang-ncar Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/dynamics/mpas/assets/Makefile.in.CESM
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,14 @@ libmpas-apply-patch:

# Combine multiple static libraries into `libmpas.a` via archiver/MRI script. This requires GNU or GNU-like archiver (`ar`) program.
libmpas-archiver-script.txt:
@echo "create libmpas.a" > $(@)
@echo "addlib libdycore.a" >> $(@)
@echo "addlib libframework.a" >> $(@)
@echo "addlib libops.a" >> $(@)
@echo "addmod dyn_mpas_subdriver.o" >> $(@)
@echo "save" >> $(@)
@echo "end" >> $(@)
@echo "create libmpas.a" > $(@)
@echo "addlib libdycore.a" >> $(@)
@echo "addlib libframework.a" >> $(@)
@echo "addlib libops.a" >> $(@)
@echo "addmod dyn_mpas_procedures.o" >> $(@)
@echo "addmod dyn_mpas_subdriver.o" >> $(@)
@echo "save" >> $(@)
@echo "end" >> $(@)

.PHONY: libmpas-preview
libmpas-preview: libmpas-apply-patch libmpas-archiver-script.txt
Expand Down Expand Up @@ -161,7 +162,9 @@ endif
( cd external; $(MAKE) FC="$(FC)" SFC="$(SFC)" CC="$(CC)" SCC="$(SCC)" FFLAGS="$(FFLAGS)" CFLAGS="$(CFLAGS)" CPP="$(CPP)" NETCDF="$(NETCDF)" CORE="$(CORE)" ezxml-lib )

.PHONY: subdrv
subdrv: driver/dyn_mpas_subdriver.o
subdrv: driver/dyn_mpas_procedures.o driver/dyn_mpas_subdriver.o

driver/dyn_mpas_subdriver.o: driver/dyn_mpas_procedures.o

%.o: %.F90 dycore frame ops
( cd $(<D); $(FC) $(CPPFLAGS) $(FFLAGS) -c $(<F) $(CPPINCLUDES) $(FCINCLUDES) -I../framework -I../operators -I../core_$(CORE) -I../core_$(CORE)/dynamics )
Expand Down
Loading