Skip to content

Remove unused pver argument in press_lim_idx (match ESCOMP/CAM)#399

Merged
jimmielin merged 2 commits into
ESCOMP:developmentfrom
jimmielin:hplin/remove_pver_press_lim_idx
Jun 25, 2025
Merged

Remove unused pver argument in press_lim_idx (match ESCOMP/CAM)#399
jimmielin merged 2 commits into
ESCOMP:developmentfrom
jimmielin:hplin/remove_pver_press_lim_idx

Conversation

@jimmielin

Copy link
Copy Markdown
Collaborator

Tag name (required for release branches):
Originator(s): @jimmielin

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

Describe any changes made to build system: N/A

Describe any changes made to the namelist: N/A

List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A

List all files eliminated and why: N/A

List all files added and what they do: N/A

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M       src/data/ref_pres.F90
   - remove unused `pver` argument in `press_lim_idx` to match the function interface in ESCOMP/CAM

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima:

derecho/gnu/aux_sima:

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

@jimmielin
jimmielin requested a review from nusbaume June 23, 2025 20:12
@jimmielin jimmielin self-assigned this Jun 23, 2025
@jimmielin

Copy link
Copy Markdown
Collaborator Author

Hi @nusbaume, I've requested a review from you on this (hopefully straightforward change) since you're the original author of this file from back in 2021 and it wasn't immediately obvious to me whether the added pver argument compared to CAM is/was intentional.

Either way I hope we can have the same interface between CAM and CAM-SIMA since I need to use press_lim_idx as a dependency in a converted vertical diffusion scheme. Thanks!

@jimmielin
jimmielin force-pushed the hplin/remove_pver_press_lim_idx branch from e45f04f to a863dd7 Compare June 23, 2025 20:16

@nusbaume nusbaume left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimmielin!

@nusbaume nusbaume added the code clean-up Made code simpler, better, and/or easier to read. label Jun 25, 2025
@jimmielin
jimmielin requested a review from peverwhee June 25, 2025 15:04
@jimmielin

Copy link
Copy Markdown
Collaborator Author

all regression tests passed

@jimmielin
jimmielin merged commit e252454 into ESCOMP:development Jun 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code clean-up Made code simpler, better, and/or easier to read.

Projects

Status: Tag

Development

Successfully merging this pull request may close these issues.

4 participants