Remove unused pver argument in press_lim_idx (match ESCOMP/CAM)#399
Merged
jimmielin merged 2 commits intoJun 25, 2025
Merged
Conversation
Collaborator
Author
|
Hi @nusbaume, I've requested a review from you on this (hopefully straightforward change) since you're the original author of this file from back in 2021 and it wasn't immediately obvious to me whether the added Either way I hope we can have the same interface between CAM and CAM-SIMA since I need to use |
jimmielin
force-pushed
the
hplin/remove_pver_press_lim_idx
branch
from
June 23, 2025 20:16
e45f04f to
a863dd7
Compare
Collaborator
Author
|
all regression tests passed |
peverwhee
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches):
Originator(s): @jimmielin
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
pverargument inpress_lim_idxto match the function interface in ESCOMP/CAM (https://github.com/ESCOMP/CAM/blob/cam_development/src/physics/cam/ref_pres.F90#L176)Describe any changes made to build system: N/A
Describe any changes made to the namelist: N/A
List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A
List all files eliminated and why: N/A
List all files added and what they do: N/A
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: