Skip to content

Impose range limits on mid-level pressure in MPAS dynamics-physics coupling#391

Merged
kuanchihwang merged 4 commits into
ESCOMP:developmentfrom
kuanchihwang:staging/mpas-dycore-bounded-mid-pres
Jul 3, 2025
Merged

Impose range limits on mid-level pressure in MPAS dynamics-physics coupling#391
kuanchihwang merged 4 commits into
ESCOMP:developmentfrom
kuanchihwang:staging/mpas-dycore-bounded-mid-pres

Conversation

@kuanchihwang

@kuanchihwang kuanchihwang commented May 21, 2025

Copy link
Copy Markdown
Collaborator

Tag name (required for release branches):

None

Originator(s):

kuanchihwang

Descriptions (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

This PR ports a bug fix from ESCOMP/CAM#1304 to CAM-SIMA. In MPAS dynamics-physics coupling, mid-level pressure is not bounded by interface pressure. In high-resolution simulations, the former could exceed the latter, leading to a model crash in physics. Therefore, impose range limits on mid-level pressure to ensure that it is bounded by interface pressure.

Closes #388

Describe any changes made to the build system:

None

Describe any changes made to the namelist:

None

List any changes to the defaults for the input datasets (e.g., boundary datasets):

None

List all files eliminated and why:

None

List all files added and what they do:

None

List all existing files that have been modified, and describe the changes:

M       src/dynamics/mpas/dyn_coupling.F90
  * Limit mid-level pressure within the range of interface pressure
  * Remove debugging block
  * Correct code comments

Regression tests:

No changes to any existing tests. All tests pass with respect to the last baseline, sima0_06_000.

@kuanchihwang
kuanchihwang requested review from mgduda and nusbaume May 21, 2025 06:20

@nusbaume nusbaume left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kuanchihwang!

@nusbaume
nusbaume requested a review from cacraigucar June 25, 2025 16:54
@kuanchihwang
kuanchihwang merged commit 635fa21 into ESCOMP:development Jul 3, 2025
12 checks passed
@kuanchihwang
kuanchihwang deleted the staging/mpas-dycore-bounded-mid-pres branch July 3, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants