Skip to content

Cam sima dycore update#344

Open
PeterHjortLauritzen wants to merge 52 commits into
ESCOMP:developmentfrom
PeterHjortLauritzen:CAM-SIMA-dycore-update
Open

Cam sima dycore update#344
PeterHjortLauritzen wants to merge 52 commits into
ESCOMP:developmentfrom
PeterHjortLauritzen:CAM-SIMA-dycore-update

Conversation

@PeterHjortLauritzen

@PeterHjortLauritzen PeterHjortLauritzen commented Dec 27, 2024

Copy link
Copy Markdown
Collaborator

Tag name (required for release branches):
Originator(s):

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

This PR should enable the use of the SE dycore with the CAM4 physics suite.

Describe any changes made to build system:

Describe any changes made to the namelist:

List any changes to the defaults for the input datasets (e.g. boundary datasets):

List all files eliminated and why:

List all files added and what they do:

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima:

derecho/gnu/aux_sima:

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

@jimmielin jimmielin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PeterHjortLauritzen! Some early comments.

I think there are a handful of instances in the dycore that have code walled off using #ifdef 0 and a comment, for much of the code that depends on tracers/chemistry/constituents and history, which were previously unsupported. Not sure if we should begin to implement these now or continue to wall these off (perhaps in a constituent manner to what is there now, i.e., change all to #ifdef 0) so they can be dealt with together at a later time.

Comment thread cime_config/namelist_definition_cam.xml Outdated
Comment thread cime_config/namelist_definition_cam.xml Outdated
Comment thread cime_config/namelist_definition_cam.xml Outdated
Comment thread src/dynamics/se/dp_coupling.F90 Outdated
Comment thread src/dynamics/se/dycore/control_mod.F90 Outdated
Comment thread src/dynamics/se/advect_tend.F90 Outdated
Comment thread src/dynamics/se/stepon.F90 Outdated
@jimmielin

Copy link
Copy Markdown
Collaborator

Note -- maybe it could be addressed in this PR: To support CAM7 moving mountain gravity waves the vort4gw code needs to be ported from CAM to the SE dycore code here as well (instead of using the pbuf just populate vorticity in physics_state so it is visible to the CCPP schemes via the CAM-SIMA registry)

@PeterHjortLauritzen

PeterHjortLauritzen commented Nov 24, 2025

Copy link
Copy Markdown
Collaborator Author

FYI: In FKESSLER (10 day test) solution is B4B with cam_development tag cam6_4_089 when performance enhacement PR has been committed (ESCOMP/CAM#1365)

@jimmielin jimmielin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PeterHjortLauritzen!

Since this is bit-for-bit with cam_development and I have no further questions about the code I'll approve it from my end! Depending on whether this or the gravity waves PR goes in first I'm happy to handle whatever merge conflicts arise due to vorticity code updates in the GW PR that also affect the SE dycore.

Comment thread cime_config/namelist_definition_cam.xml Outdated
Comment thread src/dynamics/se/stepon.F90 Outdated
@nusbaume
nusbaume marked this pull request as ready for review February 18, 2026 18:59
@nusbaume
nusbaume temporarily deployed to CI-tests-on-CIRRUS March 27, 2026 17:12 — with GitHub Actions Inactive
@nusbaume
nusbaume temporarily deployed to CI-tests-on-CIRRUS March 27, 2026 20:00 — with GitHub Actions Inactive
@nusbaume
nusbaume temporarily deployed to CI-tests-on-CIRRUS April 5, 2026 23:51 — with GitHub Actions Inactive
@nusbaume
nusbaume temporarily deployed to CI-tests-on-CIRRUS April 15, 2026 14:24 — with GitHub Actions Inactive
@nusbaume
nusbaume temporarily deployed to CI-tests-on-CIRRUS April 15, 2026 17:19 — with GitHub Actions Inactive
Note that CAM-SIMA currently still requires the source (e.g. F90)
file to be present in SourceMods as well, but at least now metadata
files will be seen in the case where both are present.
@nusbaume
nusbaume had a problem deploying to CI-tests-on-CIRRUS June 16, 2026 19:57 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants