Prompting Unauthenticated Users to sign in first to upvote a story #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrinishant
changed the title
cyntss
reviewed
Mar 11, 2022
src/components/AuthWrapper.jsx
Outdated
| @@ -4,6 +4,7 @@ import LanguageDropdown from './LanguageDropdown' | |||
| import eosIcon from '../assets/images/user-story-logo.svg' | |||
| import SocialMediaLinks from '../components/SocialMediaLinks' | |||
| import { EOS_COPYRIGHT } from 'eos-icons-react' | |||
| import { Link } from '@reach/router' | |||
There was a problem hiding this comment.
this issue seems to already have been addressed in #162
Please remove these changes from this PR so that the other one can be merged
cyntss
reviewed
Mar 11, 2022
src/components/StoryPageTimeline.js
Outdated
| <Modal | ||
| content={ | ||
| <> | ||
| <div> |
There was a problem hiding this comment.
try not to use too many empty divs that don't even have classes. Titles are display block elements, they don't need to be encapsulated in divs
cyntss
reviewed
Mar 11, 2022
src/components/Vote.js
Outdated
| if (userId && !voteClicked) { | ||
| updateVote(story) | ||
| } else if (!userId) { | ||
| console.log('Not loged In') |
There was a problem hiding this comment.
Avoid leaving console logs in production. They don't add value to users
cyntss
reviewed
Mar 11, 2022
src/components/StoryPageTimeline.js
Outdated
| if (userId && !voteClicked) updateVote(story) | ||
| if (userId && !voteClicked) { | ||
| updateVote(story) | ||
| console.log('even after being logged') |
There was a problem hiding this comment.
Avoid leaving console logs in production. They don't add value to users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
fixes #150
Describe the changes you've made
I have used a state to look for whether the modal should be shown or not, and have set this to true if the user is not sign-in/authenticated and tries to upvote for the story. I've used the Modal component (which was already there in the project) to prompt the user. And have made the upvote button clickable and hovering mouse on it to pointer, in case of unauthenticated user (which was not so earlier)
Describe if there is any unusual behavior (Any Warning) of your code(Write
NAif there isn't)NA
Additional context (OPTIONAL)
Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.
Logout yourself (if already login) and then go to any of the story available and try to click on upvote button and you should see a prompting modal asking you to sign in first to upvote for the story.
Checklist
Provide a Deployed link of route/page that needs to review
Preview: Deploy preview link here with the appropriate route