-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft EWS Integration with phpEWS library into [mail] app #15
Open
filkaris
wants to merge
80
commits into
EGroupware:master
Choose a base branch
from
filkaris:ews_project
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did you have a chance to take a look at this? If more time goes by, I might not be able to support this as easily, since we will be wokring on other parts of the software. |
…into ews_project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first version of the integration we talked about.
The Integration essentially creates a new type for "imap" accounts, which uses Api\Mail_EWS instead of Api\Mail.
Api\Mail_EWS implements Api\Mail's functionality.
There are also a few more classes added.
In some case we implement empty functions, just because they are needed by the system in the IMAP cases.
Unfortunately Api\Mail and class.mail_ui.inc.php were not completely separated from the IMAP logic and the Horde objects, so we did the best we could to keep the system functional in both cases with minimal changes.
There is a lot to cover and we'll be here for any additions/changes needed.