Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the mount_secrets_volume option to the configuration #150

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Move the mount_secrets_volume option to the configuration #150

merged 1 commit into from
Nov 25, 2024

Conversation

enolfc
Copy link
Contributor

@enolfc enolfc commented Nov 25, 2024 •
edited
Loading

Summary

Add a new option for the spawner mount_secrets_volume that will determine whether the secrets volume is mounted or not in the user environment (but still potentially available in the sidecars). As being part of the spawner configuration, it can be used in the kubespawner_overrides:

singleuser:
  profileList:
    - display_name: Default environment
      description: >
        The default notebook environment includes Python, R, Julia and Octave kernels.
      default: true
      kubespawner_override:
        args:
          - "--CondaKernelSpecManager.env_filter='/opt/conda$'"
    - display_name: No secrets environment
      description: >
        Look ma! no screts.
      kubespawner_override:
        args:
          - "--CondaKernelSpecManager.env_filter='/opt/conda$'"
        mount_secrets_volume: false

Related issue :

@enolfc enolfc changed the title Move the mount_secrets option to the configuration Move the mount_secrets_volume option to the configuration Nov 25, 2024
gonimoro
gonimoro approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@gonimoro gonimoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@enolfc enolfc merged commit ba7e204 into EGI-Federation:main Nov 25, 2024
3 checks passed
@enolfc enolfc deleted the mount_secrets branch November 25, 2024 12:57
enolfc added a commit to enolfc/egi-notebooks-hub that referenced this pull request Nov 27, 2024
@enolfc
Move the mount_secrets option to the configuration (EGI-Federation#150)
b0e265e
enolfc added a commit that referenced this pull request Nov 27, 2024
@enolfc @gonimoro
Prepare changelog for v0.3.0 (#147)
8dfedb6 
* Prepare changelog for v0.3.0

* Add EGI templates update

* Update changes

* Updating EC templates (#146)

* Updating EC templates

* Updating current templates with newest Jupyterhub 5 template updates
  from https://github.com/jupyterhub/jupyterhub/tree/a8500a31a9bc77a9829e903693462a7da38fee52/share/jupyterhub/templates

* Fixing broken template

* Fixing template content alignment

* Fix linting

---------

Co-authored-by: gonimoro <>

* Move the mount_secrets option to the configuration (#150)

* Make sure that groups are recreated (#149)

* Make sure that groups are recreated

* Do get refreshed user info as well

* Fix the refresh mechanism

* Add pre_spawn_hook method again (#151)

* EGI Templates update (#143)

* EGI Notebooks logo

* Move most of the EGI CSS into a separate file

* Update style of Notebooks front page

Update also styles to work with JupyterHub v5 and minor text fixes

* Linting fixes

* Ready to go

---------

Co-authored-by: gonimoro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonimoro gonimoro gonimoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enolfc @gonimoro