Use exact decimal arithmetic for payments, fees, quotes, and limits - #172
Merged
Conversation
…metic-for-calculations Use exact decimal arithmetic for payments
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Gozirimdev
requested changes
Aug 20, 2026
Contributor
There was a problem hiding this comment.
This PR cannot be merged as linked. It says it closes #160, but #160 is about voice-note security and privacy; this PR contains decimal-payment changes.
Please either:
- change the PR to implement issue #160 fully, or
- link the correct issue and remove the incorrect closure.
If this is intended as decimal work, also fix mixed-asset compliance totals, exact rate parsing, configured fiat support, and existing-value reconciliation. It also overlaps with PR #171, so the duplicate work needs to be resolved.
…d-functionality Fix decimal payment compliance edge cases
Gozirimdev
approved these changes
Aug 22, 2026
Gozirimdev
left a comment
Contributor
There was a problem hiding this comment.
The core decimal-arithmetic implementation is substantial and the remaining precision-policy, currency-separation, and reconciliation work is tracked in unassigned issue #181.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch from floating-point to decimal arithmetic for all payment-related calculations to ensure precision and avoid rounding errors.
Changes
Impact
Closes #154
Remaining hardening is tracked separately in #181.