Skip to content

Conversation

@smoors
Copy link
Collaborator

@smoors smoors commented Nov 14, 2025

is_ci_test is simpler than having to set both bench_name and bench_name_ci.
it's also easier to understand and to explain :)

bench_name and bench_name_ci are still used is some test, i'm wondering if maybe we should remove it completely? (will be for another PR in any case)

see also the companion docs PR:

@smoors smoors changed the title use is_ci_test were appropriate use is_ci_test where appropriate Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant