1M test case which should also become CI [Ready for review] #278

satishskamath · 2025-07-31T12:01:52Z

No description provided.

casparvl · 2025-08-14T13:11:04Z

[==========] Started on Thu Aug 14 14:58:33 2025+0200

[----------] start processing checks
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=4_cores %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /761c05e6 @snellius:rome+default
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=4_cores %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /761c05e6 @snellius:genoa+default
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=4_cores %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /7ff7decc @snellius:rome+default
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=4_cores %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /7ff7decc @snellius:genoa+default
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=2_cores %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /7f4b8ada @snellius:rome+default
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=2_cores %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /7f4b8ada @snellius:genoa+default
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=2_cores %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /1f1a199c @snellius:rome+default
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=2_cores %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /1f1a199c @snellius:genoa+default
[       OK ] (1/8) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=4_cores %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /761c05e6 @snellius:genoa+default
P: perf: 2.066666666666667 s/timestep (r:0, l:None, u:None)
[       OK ] (2/8) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=4_cores %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /7ff7decc @snellius:genoa+default
P: perf: 2.066666666666667 s/timestep (r:0, l:None, u:None)
[       OK ] (3/8) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=2_cores %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /7f4b8ada @snellius:genoa+default
P: perf: 3.3333333333333335 s/timestep (r:0, l:None, u:None)
[       OK ] (4/8) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=4_cores %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /7ff7decc @snellius:rome+default
P: perf: 3.466666666666667 s/timestep (r:0, l:None, u:None)
[       OK ] (5/8) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=4_cores %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /761c05e6 @snellius:rome+default
P: perf: 3.533333333333333 s/timestep (r:0, l:None, u:None)
[       OK ] (6/8) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=2_cores %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /1f1a199c @snellius:genoa+default
P: perf: 3.4 s/timestep (r:0, l:None, u:None)
[       OK ] (7/8) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=2_cores %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /7f4b8ada @snellius:rome+default
P: perf: 4.4 s/timestep (r:0, l:None, u:None)
[       OK ] (8/8) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=2_cores %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /1f1a199c @snellius:rome+default
P: perf: 4.466666666666667 s/timestep (r:0, l:None, u:None)
[----------] all spawned checks have finished

[  PASSED  ] Ran 8/8 test case(s) from 4 check(s) (0 failure(s), 0 skipped, 0 aborted)
[==========] Finished on Thu Aug 14 15:01:38 2025+0200

Looks promising. I don't have time for a full code review now, but at least the test works for me.

One thing I noticed: There are node sizes for which neither the 1M or 8M test is run (1_8_node). I'm not sure if it makes sense, but it may be nice if every node size runs at least one of these tests.

satishskamath · 2025-08-17T19:44:23Z

@casparvl I have fixed the scale. Now all relevant scales until 2_nodes are present. There is a limit to number of tasks though, for any scale if it exceeds more than 128 MPI tasks, then that test is skipped with a relevant message.

[satishk@tcn3 projects]$ reframe -C eessi_reframe/settings_example.py -c test-suite/eessi/testsuite/tests/apps/openfoam/openfoam.py  --system=snellius_eessi:cpu_genoa
 -t CI -r
[ReFrame Setup]
  version:           4.6.1
  command:           '/home/satishk/.local/easybuild/RHEL8/2023/software/ReFrame/4.6.1/bin/reframe -C eessi_reframe/settings_example.py -c test-suite/eessi/testsuite/
tests/apps/openfoam/openfoam.py --system=snellius_eessi:cpu_genoa -t CI -r'
  launched by:       [email protected]
  working directory: '/gpfs/home5/satishk/projects'
  settings files:    '<builtin>', 'eessi_reframe/settings_example.py'
  check search path: '/gpfs/home5/satishk/projects/test-suite/eessi/testsuite/tests/apps/openfoam/openfoam.py'
  stage directory:   '/scratch-shared/satishk/reframe_output'
  output directory:  '/gpfs/home5/satishk/projects/output'
  log files:         '/gpfs/home5/satishk/projects/reframe.log'

[==========] Running 9 check(s)
[==========] Started on Sun Aug 17 21:38:38 2025+0200

[----------] start processing checks
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=2_nodes %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /f0f226d7 @snellius_eessi:cpu_genoa+default
[     SKIP ] (1/9) The maximum number of cores this test can run on is 128. Launch on a scale with lower corecount.
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1_node %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /278524e7 @snellius_eessi:cpu_genoa+default
[     SKIP ] (2/9) The maximum number of cores this test can run on is 128. Launch on a scale with lower corecount.
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1_2_node %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /75444687 @snellius_eessi:cpu_genoa+default
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1_4_node %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /74214dc7 @snellius_eessi:cpu_genoa+default
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1_8_node %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /0a8fad4a @snellius_eessi:cpu_genoa+default
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1cpn_4nodes %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /5fde18c0 @snellius_eessi:cpu_genoa+defaul
t
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1cpn_2nodes %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /d76a0a2e @snellius_eessi:cpu_genoa+defaul
t
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=4_cores %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /7ff7decc @snellius_eessi:cpu_genoa+default
[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=2_cores %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /1f1a199c @snellius_eessi:cpu_genoa+default
[       OK ] (3/9) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1cpn_4nodes %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /5fde18c0 @snellius_eessi:cpu_genoa+
default
P: perf: 1.8 s/timestep (r:0, l:None, u:None)
[       OK ] (4/9) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1_8_node %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /0a8fad4a @snellius_eessi:cpu_genoa+def
ault
P: perf: 0.4 s/timestep (r:0, l:None, u:None)
[       OK ] (5/9) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1_2_node %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /75444687 @snellius_eessi:cpu_genoa+def
ault
P: perf: 0.13333333333333333 s/timestep (r:0, l:None, u:None)
[       OK ] (6/9) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1_4_node %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /74214dc7 @snellius_eessi:cpu_genoa+def
ault
P: perf: 0.2 s/timestep (r:0, l:None, u:None)
[       OK ] (7/9) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1cpn_2nodes %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /d76a0a2e @snellius_eessi:cpu_genoa+
default
P: perf: 3.2666666666666666 s/timestep (r:0, l:None, u:None)
[       OK ] (8/9) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=4_cores %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /7ff7decc @snellius_eessi:cpu_genoa+defa
ult
P: perf: 2.4 s/timestep (r:0, l:None, u:None)
[       OK ] (9/9) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=2_cores %device_type=cpu %module_name=OpenFOAM/v2312-foss-2023a /1f1a199c @snellius_eessi:cpu_genoa+defa
ult
P: perf: 3.2666666666666666 s/timestep (r:0, l:None, u:None)
[----------] all spawned checks have finished

[  PASSED  ] Ran 7/9 test case(s) from 9 check(s) (0 failure(s), 2 skipped, 0 aborted)
[==========] Finished on Sun Aug 17 21:41:16 2025+0200
Log file(s) saved in '/gpfs/home5/satishk/projects/reframe.log'
[satishk@tcn3 projects]$

laraPPr · 2025-09-24T13:55:37Z

[==========] Running 9 check(s)

[==========] Started on Wed Sep 24 15:52:03 2025+0200



[----------] start processing checks

[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=2_cores %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /7f4b8ada @hortense:cpu_milan_rhel9+default

[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=4_cores %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /761c05e6 @hortense:cpu_milan_rhel9+default

[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1cpn_2nodes %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /203043c4 @hortense:cpu_milan_rhel9+default

[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1cpn_4nodes %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /282c3cb5 @hortense:cpu_milan_rhel9+default

[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1_8_node %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /2b141c7b @hortense:cpu_milan_rhel9+default

[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1_4_node %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /2321f97f @hortense:cpu_milan_rhel9+default

[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1_2_node %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /6e55c59d @hortense:cpu_milan_rhel9+default

[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1_node %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /781099e2 @hortense:cpu_milan_rhel9+default

[ RUN      ] EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=2_nodes %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /97a67022 @hortense:cpu_milan_rhel9+default

[     SKIP ] (1/9) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=2_nodes %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /97a67022 @hortense:cpu_milan_rhel9+default [The maximum number of cores this test can run on is 128. Launch on a scale with lower corecount.]

[       OK ] (2/9) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1_4_node %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /2321f97f @hortense:cpu_milan_rhel9+default

P: perf: 0.3333333333333333 s/timestep (r:0, l:None, u:None)

[       OK ] (3/9) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1_2_node %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /6e55c59d @hortense:cpu_milan_rhel9+default

P: perf: 0.13333333333333333 s/timestep (r:0, l:None, u:None)

[       OK ] (4/9) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1cpn_4nodes %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /282c3cb5 @hortense:cpu_milan_rhel9+default

P: perf: 1.4 s/timestep (r:0, l:None, u:None)

[       OK ] (5/9) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1cpn_2nodes %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /203043c4 @hortense:cpu_milan_rhel9+default

P: perf: 2.6666666666666665 s/timestep (r:0, l:None, u:None)

[       OK ] (6/9) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1_8_node %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /2b141c7b @hortense:cpu_milan_rhel9+default

P: perf: 0.8666666666666667 s/timestep (r:0, l:None, u:None)

[       OK ] (7/9) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=1_node %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /781099e2 @hortense:cpu_milan_rhel9+default

P: perf: 0.2 s/timestep (r:0, l:None, u:None)

[       OK ] (8/9) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=4_cores %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /761c05e6 @hortense:cpu_milan_rhel9+default

P: perf: 4.2 s/timestep (r:0, l:None, u:None)

[       OK ] (9/9) EESSI_OPENFOAM_LID_DRIVEN_CAVITY_1M %scale=2_cores %device_type=cpu %module_name=OpenFOAM/v2406-foss-2023a /7f4b8ada @hortense:cpu_milan_rhel9+default

P: perf: 5.533333333333333 s/timestep (r:0, l:None, u:None)

[----------] all spawned checks have finished



[  PASSED  ] Ran 8/9 test case(s) from 9 check(s) (0 failure(s), 1 skipped, 0 aborted)

[==========] Finished on Wed Sep 24 15:55:11 2025+0200

Log file(s) saved in '/dodrio/scratch/projects/gadminforever/vsc46128/test-suite/logs/reframe_20250924_155143.log'

smoors · 2025-10-07T09:20:10Z

eessi/testsuite/tests/apps/openfoam/openfoam.py

+    Filtering function for filtering scales for the OpenFOAM 8M mesh test
+    returns all scales with at least half a node.


this is the same docstring as for 8M
did you forget to update it?

eessi/testsuite/tests/apps/openfoam/openfoam.py

smoors · 2025-10-12T15:44:18Z

tested on a single node in Hydra, works well.

Satish Kamath and others added 4 commits July 31, 2025 14:00

1M test case which should also become CI [WIP]

1283707

Added a different filter function for scales of 1M mesh

bee36eb

Fixed sanity issue in the 1M test.

68bf8e9

Trying to satisfy the linter

605f6eb

satishskamath changed the title ~~1M test case which should also become CI [WIP]~~ 1M test case which should also become CI [Ready for testing] Aug 14, 2025

Added CI tag to the 1M case

059c1b9

Satish Kamath and others added 4 commits August 17, 2025 14:31

Corrected Scales and fixed line skips to satisfy linter

7e3595c

Removing blank line at the end of file.

2b11238

Corrected scales now properly but needs to be tested.

196c029

Now trying to satisfy the linter.

83c9f07

satishskamath changed the title ~~1M test case which should also become CI [Ready for testing]~~ 1M test case which should also become CI [Ready for review] Aug 17, 2025

satishskamath mentioned this pull request Aug 23, 2025

OpenFOAM 64M test case [Ready for testing] #281

Open

smoors reviewed Oct 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

1M test case which should also become CI [Ready for review] #278

1M test case which should also become CI [Ready for review] #278

Uh oh!

satishskamath commented Jul 31, 2025

Uh oh!

casparvl commented Aug 14, 2025

Uh oh!

satishskamath commented Aug 17, 2025

Uh oh!

laraPPr commented Sep 24, 2025

Uh oh!

smoors Oct 7, 2025

Uh oh!

Uh oh!

Uh oh!

smoors commented Oct 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		Filtering function for filtering scales for the OpenFOAM 8M mesh test
		returns all scales with at least half a node.

1M test case which should also become CI [Ready for review] #278

Are you sure you want to change the base?

1M test case which should also become CI [Ready for review] #278

Uh oh!

Conversation

satishskamath commented Jul 31, 2025

Uh oh!

casparvl commented Aug 14, 2025

Uh oh!

satishskamath commented Aug 17, 2025

Uh oh!

laraPPr commented Sep 24, 2025

Uh oh!

smoors Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

smoors commented Oct 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants