Add configuration file for MareNostrum5 [Offline nodes] #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: laraPPr <[email protected]>
Signed-off-by: laraPPr <[email protected]>
Signed-off-by: laraPPr <[email protected]>
Signed-off-by: laraPPr <[email protected]>
casparvl
approved these changes
Jul 16, 2025
casparvl
requested changes
Jul 17, 2025
casparvl
reviewed
Jul 17, 2025
config/bsc_marenostrum5.py
Outdated
| 'launcher': 'mpirun', | ||
| 'access': ['-q gp_ehpc', '--export=None', f'-A {sbatch_account}'], | ||
| 'env_vars': [ | ||
| ['EESSI_TEST_SUITE_NO_DOWNLOAD', 'True'], |
There was a problem hiding this comment.
Maybe better EESSI_TEST_SUITE_DISABLE_DOWNLOADS
|
laraPPr
commented
Jul 18, 2025
Signed-off-by: laraPPr <[email protected]>
Signed-off-by: laraPPr <[email protected]>
laraPPr
commented
Jul 31, 2025
config/bsc_marenostrum5.py
Outdated
| 'extras': { | ||
| EXTRAS.GPU_VENDOR: GPU_VENDORS.NVIDIA, | ||
| # TODO create constant | ||
| EXTRAS.INTERNET_ACCESS: 'offline', |
There was a problem hiding this comment.
The use of this new constant should be documented
There was a problem hiding this comment.
I think this should be a feature, and not an extra. That way, one can easily use it for test selection by saying valid_systems = ['-offline'], meaning a test can't be run on systems that have the offline feature.
See also my comment at #279 (review)
casparvl
reviewed
Aug 13, 2025
config/bsc_marenostrum5.py
Outdated
| # The test-suite will give warning which can be ignored | ||
| ], | ||
| 'extras': { | ||
| # TODO create constant |
There was a problem hiding this comment.
Well, this is not a TODO anymore, right? I'd replace it, and describe what it means in a short comment (and then more extensively in the docs)
Signed-off-by: laraPPr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.