Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new GPU workflow #949

Draft
wants to merge 2 commits into
base: 2023.06-software.eessi.io
Choose a base branch
from

Conversation

laraPPr
Copy link
Collaborator

@laraPPr laraPPr commented Feb 27, 2025

to check if missing dependencies for a CUDA build include cpu builds

This action includes an action that is not allowed yet by the EESSI organisation. Could the following action https://github.com/dorny/paths-filter be added to the allowed action.

BUG FIX: It also includes a fix for the existing missing installation check. Currently it fails after running check_missing_installations.sh if their are missing installations. And the workflow is stopped directly after which means the info on which easystack cause the failure is not printed. With this change it is.

Copy link

eessi-bot bot commented Feb 27, 2025

Instance eessi-bot-mc-aws is configured to build for:

  • architectures: x86_64/generic, x86_64/intel/haswell, x86_64/intel/sapphirerapids, x86_64/intel/skylake_avx512, x86_64/amd/zen2, x86_64/amd/zen3, aarch64/generic, aarch64/neoverse_n1, aarch64/neoverse_v1
  • repositories: eessi.io-2023.06-compat, eessi.io-2023.06-software

Copy link

eessi-bot bot commented Feb 27, 2025

Instance eessi-bot-mc-azure is configured to build for:

  • architectures: x86_64/amd/zen4
  • repositories: eessi.io-2023.06-software, eessi.io-2023.06-compat

@eessi-bot-toprichard
Copy link

Instance rt-Grace-jr is configured to build for:

  • architectures: aarch64/nvidia/grace
  • repositories: eessi.io-2023.06-software

cvmfs_http_proxy: DIRECT
cvmfs_repositories: software.eessi.io
- name: find changed easystacks
uses: dorny/paths-filter@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need to use a specific commit from that repo to pass our security checks

Suggested change
uses: dorny/paths-filter@v3
uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 #v3.0.2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does something else need to be done because I'm still seeing this? https://github.com/EESSI/software-layer/actions/runs/13587202930

@hvelab
Copy link
Contributor

hvelab commented Mar 4, 2025

  • Agreed that we don't need the action but is better to do it ourselves
  • The other option is to accept -> but security concerns

@@ -60,8 +60,7 @@ jobs:
echo "just run check_missing_installations.sh (should use easystacks/software.eessi.io/${{matrix.EESSI_VERSION}}/eessi-${{matrix.EESSI_VERSION}}-*.yml with latest EasyBuild release)"
for easystack_file in $(EESSI_VERSION=${{matrix.EESSI_VERSION}} .github/workflows/scripts/only_latest_easystacks.sh); do
echo "check missing installations for ${easystack_file}..."
./check_missing_installations.sh ${easystack_file}
ec=$?
./check_missing_installations.sh ${easystack_file} || ec=$?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work, it only sets ec if the script did not exit successfully

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is what I want otherwise the workflow stops. And than this error message does not get printed "missing installations found for ${easystack_file}!"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tested it with an easystack were everything was already installed and that went fine as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can test again to see if I overlooked something.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no your right

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok than I'll have to find another way around it

@laraPPr laraPPr marked this pull request as draft March 10, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants