-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new GPU workflow #949
base: 2023.06-software.eessi.io
Are you sure you want to change the base?
Add new GPU workflow #949
Conversation
Instance
|
Instance
|
Instance
|
cvmfs_http_proxy: DIRECT | ||
cvmfs_repositories: software.eessi.io | ||
- name: find changed easystacks | ||
uses: dorny/paths-filter@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would need to use a specific commit from that repo to pass our security checks
uses: dorny/paths-filter@v3 | |
uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 #v3.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does something else need to be done because I'm still seeing this? https://github.com/EESSI/software-layer/actions/runs/13587202930
Co-authored-by: ocaisa <[email protected]>
|
@@ -60,8 +60,7 @@ jobs: | |||
echo "just run check_missing_installations.sh (should use easystacks/software.eessi.io/${{matrix.EESSI_VERSION}}/eessi-${{matrix.EESSI_VERSION}}-*.yml with latest EasyBuild release)" | |||
for easystack_file in $(EESSI_VERSION=${{matrix.EESSI_VERSION}} .github/workflows/scripts/only_latest_easystacks.sh); do | |||
echo "check missing installations for ${easystack_file}..." | |||
./check_missing_installations.sh ${easystack_file} | |||
ec=$? | |||
./check_missing_installations.sh ${easystack_file} || ec=$? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this will work, it only sets ec
if the script did not exit successfully
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that is what I want otherwise the workflow stops. And than this error message does not get printed "missing installations found for ${easystack_file}!"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tested it with an easystack were everything was already installed and that went fine as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can test again to see if I overlooked something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no your right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok than I'll have to find another way around it
to check if missing dependencies for a CUDA build include cpu builds
This action includes an action that is not allowed yet by the EESSI organisation. Could the following action https://github.com/dorny/paths-filter be added to the allowed action.
BUG FIX: It also includes a fix for the existing missing installation check. Currently it fails after running
check_missing_installations.sh
if their are missing installations. And the workflow is stopped directly after which means the info on which easystack cause the failure is not printed. With this change it is.