-
Notifications
You must be signed in to change notification settings - Fork 54
adjust SitePackage.lua for multiple CUDA/cu* modules #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust SitePackage.lua for multiple CUDA/cu* modules #798
Conversation
Instance
|
Instance
|
bot: build repo:eessi.io-2023.06-software arch:zen2 |
Updates by the bot instance
|
Updates by the bot instance
|
New job on instance
|
New job on instance
|
…-layer into 2023.06-software.eessi.io-cuDNN-8.9.2.26-part-2
Rebuild after PR got updated to resolve conflicts... bot: build repo:eessi.io-2023.06-software arch:zen2 |
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
New job on instance
|
New job on instance
|
@TopRichard can test it for @trz42 |
The changes have been tested for CUDA and cuDNN: current create_lmodsitepackage.py
Changes applied:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, and seems to work just fine given the example usage from @TopRichard
@trz42 Do I understand correctly that we need to rebuild this for all architectures? |
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:zen2 |
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
Right, we need this for all architectures where we have CUDA and friends libraries. It doesn’t hurt to have it for all architectures. Thus, we are consistent and in the future we don’t have to rebuild the SitePackage.lua if we add cuDNN later to other CPUs. |
Also, we now should remove the CUDA modules from the CPU-only directories because the new modules differ (added paths to |
Had a quick look at the details for each tarball here, all look fine (they only include the updated From my point of view the tarballs can be deployed. |
Label |
1 similar comment
Label |
All staging PRs merged |
PR merged! Moved |
PR merged! Moved |
PR merged! Moved |
This PR implements changes to the
SitePackage.lua
which takes into account that multiple CUDA and cu* modules may be included in EESSI. To date onlycuDNN
is added. Adding futurecu*
libraries/modules such ascuTENSOR
will require minimal changes tocreate_lmodsitepackage.lua
.Also, this is part 2 which together with #772 implements what was attempted originally with #581