-
Notifications
You must be signed in to change notification settings - Fork 2
add support to eessi_container.sh
for using unionfs
overlay tool
#9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
boegel
wants to merge
12
commits into
EESSI:main
Choose a base branch
from
boegel:eessi_container_unionfs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trz42
requested changes
Jun 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions
…iner.sh script Co-authored-by: Thomas Röblitz <[email protected]>
…layer-scripts into eessi_container_unionfs
boegel
commented
Jun 17, 2025
.github/workflows/tests_scripts.yml
Outdated
echo 'source /software-layer/scripts/utils.sh' >> ${test_script} | ||
echo 'source /software-layer/init/eessi_environment_variables' >> ${test_script} | ||
echo 'ls -l /software-layer-scripts/' >> ${test_script} | ||
echo 'sed -i "s/__EESSI_VERSION_DEFAULT__/${{matrix.EESSI_VERSION}}/g" init/eessi_defaults |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actual fix is here, this looks more complicated than it should because of software-layer
-> software-layer-scripts
rename...
3aaa438
to
c9b81ba
Compare
…AULT__ placeholder in init/eessi_defaults in CI workflow to test load_easybuild_module.sh script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default behavior is left unchanged.
unionfs
looks promising, haven't observed thePermission denied
issues we've been seeing when creating overlay withfuse-overlays
, but it needs to be battle-tested before we jump ship.Tested with:
(see also EESSI/filesystem-layer#226)