Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete pre-existing signature files + small fixes #309

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

trz42
Copy link
Contributor

@trz42 trz42 commented Mar 18, 2025

Small PR to deal with the case that a deploy label is set again, and then the sign script would not recreate the signature if it exists from before.

Also addresses some suggestions on values for the $sign variable (0 $\rightarrow$ 'no' and 1 $\rightarrow$ 'yes').

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa
Copy link
Member

ocaisa commented Mar 18, 2025

@trz42 Code looks good, but I have no easy way to test it...did you try it out?

@trz42
Copy link
Contributor Author

trz42 commented Mar 18, 2025

@trz42 Code looks good, but I have no easy way to test it...did you try it out?

Not, yet. Will do it tomorrow.

@trz42
Copy link
Contributor Author

trz42 commented Mar 19, 2025

@trz42 Code looks good, but I have no easy way to test it...did you try it out?

Not, yet. Will do it tomorrow.

@ocaisa seems to work as intended. See EESSI/software-layer#968 (comment)

@ocaisa ocaisa merged commit 5ff1b77 into EESSI:develop Mar 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants