Order the targets in available_software.py #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedroge
reviewed
May 2, 2025
These names get generated by Javascript maybe it is easiest to add a test in the CI to check if the number of colums correspond with the data in the json files.
|
Tested new workflow here, laraPPr#1. I hope the workflow will be triggered for the update available scripts pr once this pr gets merged. I'm not sure why it is not triggering the workflow in this pr. |
|
And the tests of the available_software.py also do not seem to be running but I ran them locally. |
|
The test for the changed available_software.py script are ran see https://github.com/EESSI/docs/actions/runs/14799376763 |
bedroge
reviewed
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also needed to fix the tests to take the ordering into account