Skip to content

fix: MfaServiceImpl과 CustomOAuth2UserService @transactional 호환성 문제 해결 #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Codemaniac7 merged 1 commit into from
Aug 29, 2025
Merged

fix: MfaServiceImpl과 CustomOAuth2UserService @transactional 호환성 문제 해결 #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/com/cMall/feedShop/user/application/service/MfaServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,8 +282,7 @@ public boolean verifyBackupCode(String email, String backupCode) {
}
}

@Transactional(propagation = Propagation.REQUIRES_NEW)
public boolean verifyBackupCodeInNewTransaction(String email, String backupCode) {
private boolean verifyBackupCodeInNewTransaction(String email, String backupCode) {
String maskedEmail = LogMaskingUtil.maskEmail(email);
String maskedBackupCode = LogMaskingUtil.maskBackupCode(backupCode);

Expand Down
3 changes: 1 addition & 2 deletions src/main/java/com/cMall/feedShop/user/infrastructure/oauth/CustomOAuth2UserService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ public OAuth2User loadUser(OAuth2UserRequest userRequest) throws OAuth2Authentic
}
}

@Transactional(propagation = Propagation.REQUIRES_NEW)
public OAuth2User processAndSaveOAuth2UserInNewTransaction(OAuth2UserRequest userRequest, OAuth2User oAuth2User) {
private OAuth2User processAndSaveOAuth2UserInNewTransaction(OAuth2UserRequest userRequest, OAuth2User oAuth2User) {
// 1. Get user info (same as before)
String registrationId = userRequest.getClientRegistration().getRegistrationId();
OAuth2UserInfo oAuth2UserInfo = OAuth2UserInfoFactory.getOAuth2UserInfo(registrationId, oAuth2User.getAttributes());
Expand Down
Loading